Skip to content

Diagnostic pkg test #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 22, 2025
Merged

Diagnostic pkg test #10

merged 7 commits into from
Apr 22, 2025

Conversation

Nabil-Salah
Copy link
Contributor

@Nabil-Salah Nabil-Salah commented Mar 5, 2025

This pr adds :

  • tests for pkg/diagnostics
  • workflow to run tests
  • fixed ci linting problems
  • fixed pkg/geoip/geoip_test.go failing tests

related issues:
threefoldtech/zos#2294

came with new issue:
#19

Signed-off-by: nabil salah <nabil.salah203@gmail.com>
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
@Nabil-Salah Nabil-Salah marked this pull request as ready for review March 6, 2025 15:06
@Nabil-Salah Nabil-Salah self-assigned this Mar 9, 2025
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
@Nabil-Salah Nabil-Salah requested a review from ashraffouda March 12, 2025 14:17
Eslam-Nawara added a commit that referenced this pull request Apr 14, 2025
@ashraffouda ashraffouda merged commit 750a050 into main Apr 22, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants