Fix error when 2 or more veth pairs share the same peer_ifindex #199
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoNovais181
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses an issue in the handling of Docker container network interfaces within tcconfig. Previously, the application enforced uniqueness on both ifindex and peer_ifindex for veth pairs. However, in Docker environments, while each veth pair is unique, the peer_ifindex can be the same across different containers. This incorrect assumption led to traffic control rules being applied only to the veth pair with the lexicographically first name, leaving others unconfigured.
Changes Made:
Modified the in-memory simplesql database schema to remove the uniqueness constraint on peer_ifindex.
Related Issues:
Fixes #168, fixes #104