Skip to content

feat: add support for producing kakfa messages asynchronously #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

doriandekoning
Copy link

@doriandekoning doriandekoning commented Mar 27, 2025

Description

Still work in progress, currently the syncproducer blocks sometimes for us causing significant request timeouts.

Closes issue(s)

Resolve #

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 3830d82
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/67e52aaaaede1e0008fa9a62

@doriandekoning doriandekoning force-pushed the add-async-kafka-producer branch from 40933b2 to fc704e7 Compare March 27, 2025 09:53
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (7912e94) to head (3830d82).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
exporter/kafkaexporter/exporter.go 35.29% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3246      +/-   ##
==========================================
- Coverage   85.15%   84.57%   -0.58%     
==========================================
  Files         121      122       +1     
  Lines        5666     5719      +53     
==========================================
+ Hits         4825     4837      +12     
- Misses        667      702      +35     
- Partials      174      180       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@doriandekoning doriandekoning force-pushed the add-async-kafka-producer branch from fc704e7 to 5918ed7 Compare March 27, 2025 10:32
@doriandekoning doriandekoning marked this pull request as draft March 27, 2025 10:33
@doriandekoning doriandekoning changed the title WIP: feat: add support for producing kakfa messages asynchronously feat: add support for producing kakfa messages asynchronously Mar 27, 2025
@doriandekoning doriandekoning force-pushed the add-async-kafka-producer branch 2 times, most recently from f5ced56 to 8510c80 Compare March 27, 2025 10:37
@doriandekoning doriandekoning force-pushed the add-async-kafka-producer branch from 8510c80 to 3830d82 Compare March 27, 2025 10:38
Copy link

@thomaspoignant thomaspoignant removed their assignment Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants