Skip to content

Update to new geom defaults #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

Update to new geom defaults #332

merged 2 commits into from
Jun 18, 2025

Conversation

teunbrand
Copy link
Collaborator

Hi Thomas,

This PR is mostly a demonstration for showing how we could bridge the old static default aesthetics to the new dynamic aesthetics while preserving backward compatibility.

There is nothing broken that will require this PR, but you might consider including it in the next ggforce release.

@teunbrand
Copy link
Collaborator Author

Marking this as draft until tidyverse/ggplot2#6285 is resolved, which would require a few tweaks.

@teunbrand
Copy link
Collaborator Author

Should now work with the latest theme gimmicks

devtools::load_all("~/packages/test/ggforce/")
#> ℹ Loading ggforce
#> Loading required package: ggplot2

ggplot(mpg, aes(displ, hwy, group = drv)) +
  geom_point() +
  geom_mark_hull() +
  theme_gray(ink = "red") +
  theme(geom.mark.hull = element_geom(bordertype = 2))

Created on 2025-03-25 with reprex v2.1.1

@teunbrand teunbrand marked this pull request as ready for review March 25, 2025 15:42
@thomasp85 thomasp85 merged commit af9a55b into thomasp85:main Jun 18, 2025
8 of 12 checks passed
@teunbrand teunbrand deleted the new_theme branch June 18, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants