1.29.0-0.5.9: Fix ens on non-ethereum networks - filter out detectedwallet (#633)

* 1.29.0-0.5.9: Fix ens on non-ethereum networks - filter out detected wallet
* Version bump
* Fix typo

Author: taylorjdawson

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bnc-onboard",
-  "version": "1.29.0-0.5.8",
+  "version": "1.29.0-0.5.9",
   "description": "Onboard users to web3 by allowing them to select a wallet, get that wallet ready to transact and have access to synced wallet state.",
   "keywords": [
     "ethereum",

src/modules/select/index.ts

@@ -50,6 +50,13 @@ function select(
     : desktopDefaultWalletNames
 
   if (wallets) {
+    // For backwards compatibility if a user is still using 'detectedwallet' in the onboard wallet select array
+    // it will be filtered out so there are no duplicates
+    wallets = wallets.filter(
+      wallet =>
+        'walletName' in wallet ? wallet.walletName !== 'detectedwallet' : true // It is not a WalletInitOption but rather a WalletModule so let it through
+    )
+
     // If we detect an injected wallet then place the detected wallet
     // at the beginning of the list e.g. the of the wallet select modal
     if (injectedWalletDetected()) {
@@ -59,7 +66,7 @@ function select(
       wallets.map(wallet => {
         // If this is a wallet init object then load the built-in wallet module
         if (isWalletInit(wallet)) {
-          const { walletName, ...initParams } = wallet as WalletInitOptions
+          const { walletName, ...initParams } = wallet
           try {
             return getModule(walletName).then((m: any) =>
               m.default({ ...initParams, networkId, isMobile })

src/utilities.ts

@@ -70,8 +70,8 @@ export function getAddress(provider: any): Promise<string | any> {
 
 export async function getEns(provider: any, address: string): Promise<Ens> {
   const { networkId } = get(app)
-  const ens = new ENS({ provider, ensAddress: getEnsAddress(networkId) })
   try {
+    const ens = new ENS({ provider, ensAddress: getEnsAddress(networkId) })
     const { name } = await ens.getName(address)
     const nameInterface = await ens.name(name)
     const contentHash = await nameInterface?.getContent()
@@ -83,7 +83,7 @@ export async function getEns(provider: any, address: string): Promise<Ens> {
       getText: nameInterface?.getText.bind(nameInterface)
     }
   } catch (e) {
-    // Error getting ens name
+    // Error getting ens
     return {}
   }
 }