Skip to content

Commit 2049d88

Browse files
1.29.0-0.5.8: [fix] keepkey message signing (#630)
* `HookedWalletSubprovider`'s `signMessage` and `signPersonalMessage` expect `0x`-prefixed hex strings, while `hdwallet-keepkey` expects a UTF-8 string. * Version bump + fix formatting Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
1 parent 1a190c2 commit 2049d88

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "bnc-onboard",
3-
"version": "1.29.0-0.5.7",
3+
"version": "1.29.0-0.5.8",
44
"description": "Onboard users to web3 by allowing them to select a wallet, get that wallet ready to transact and have access to synced wallet state.",
55
"keywords": [
66
"ethereum",

src/modules/select/wallets/keepkey/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
/* eslint-disable @typescript-eslint/camelcase */
2+
import * as ethUtil from 'ethereumjs-util'
23
import {
34
CommonWalletOptions,
45
Helpers,
@@ -406,7 +407,7 @@ async function createKeepKeyProvider({
406407

407408
const { signature } = await keepKeyWallet.ethSignMessage({
408409
addressNList,
409-
message
410+
message: ethUtil.toBuffer(message).toString('utf8')
410411
})
411412

412413
return signature

0 commit comments

Comments
 (0)