Merge branch 'develop' into feature/hardware-wallets

Author: lnbc1QWFyb24

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bnc-onboard",
-  "version": "1.2.0",
+  "version": "1.2.3",
   "description": "Onboard users to web3 by allowing them to select a wallet, get that wallet ready to transact and have access to synced wallet state.",
   "keywords": [
     "ethereum",
@@ -47,7 +47,7 @@
     "@portis/web3": "^2.0.0-beta.42",
     "@toruslabs/torus-embed": "^0.2.11",
     "@walletconnect/web3-provider": "^1.0.0-beta.45",
-    "authereum": "^0.0.4-beta.26",
+    "authereum": "^0.0.4-beta.88",
     "bignumber.js": "^9.0.0",
     "bnc-sdk": "1.0.3",
     "bowser": "^2.5.2",

src/interfaces.ts

@@ -98,7 +98,10 @@ export interface Helpers {
   getAddress: (provider: any) => Promise<string | any>
   getNetwork: (provider: any) => Promise<number | any>
   getBalance: (provider: any) => Promise<string | any>
-  resetWalletState: (options: { disconnected?: boolean }) => void
+  resetWalletState: (options?: {
+    disconnected: boolean
+    walletName: string
+  }) => void
 }
 
 export interface WalletInterface {
@@ -159,16 +162,23 @@ export interface TorusOptions {
   enableLogging?: boolean
 }
 
-export interface WalletInitOptions
-  extends CommonWalletOptions,
-    SdkWalletOptions,
-    WalletConnectOptions,
-    TorusOptions,
-    TrezorOptions,
-    LedgerOptions {
+export interface AuthereumOptions {
+  disableNotifications?: boolean
+}
+
+interface WalletName {
   walletName: string
 }
 
+export type WalletInitOptions = CommonWalletOptions &
+  SdkWalletOptions &
+  WalletConnectOptions &
+  TorusOptions &
+  TrezorOptions &
+  AuthereumOptions &
+  LedgerOptions &
+  WalletName
+
 export interface WalletCheckInit {
   checkName: string
   minimumBalance?: string

src/modules/select/index.ts

@@ -24,6 +24,10 @@ function select(
           const { walletName, ...initParams } = wallet
           const module = getModule(walletName)
 
+          if (!module) {
+            throw new Error(`${walletName} is not a valid walletName.`)
+          }
+
           return (
             module &&
             module.then((m: any) => m.default({ ...initParams, networkId }))

src/modules/select/wallets/authereum.ts

@@ -1,9 +1,9 @@
 import authereumIcon from '../wallet-icons/icon-authereum.png'
 import { networkName } from '../../../utilities'
-import { WalletModule, CommonWalletOptions } from '../../../interfaces'
+import { WalletModule, AuthereumOptions, CommonWalletOptions } from '../../../interfaces'
 
-function authereum(options: CommonWalletOptions): WalletModule {
-  const { networkId, preferred, label, iconSrc, svg } = options
+function authereum(options: AuthereumOptions & CommonWalletOptions): WalletModule {
+  const { networkId, preferred, label, iconSrc, svg, disableNotifications } = options
 
   return {
     name: label || 'Authereum',
@@ -13,7 +13,7 @@ function authereum(options: CommonWalletOptions): WalletModule {
       const { default: Authereum } = await import('authereum')
       const instance = new Authereum({
         networkName: networkName(networkId),
-        disableNotifications: true
+        disableNotifications: disableNotifications // default: false
       })
 
       const provider = instance.getProvider()
@@ -46,7 +46,7 @@ function authereum(options: CommonWalletOptions): WalletModule {
     type: 'sdk',
     desktop: true,
     mobile: true,
-    url: 'https://accounts.authereum.org/',
+    url: `https://${networkId !== 1 ? `${networkName(networkId)}.` : ''}authereum.com/`,
     preferred
   }
 }

src/modules/select/wallets/torus.ts

@@ -81,6 +81,7 @@ function torus(options: TorusOptions & CommonWalletOptions): WalletModule {
     type: 'sdk',
     desktop: true,
     mobile: true,
+    url: 'https://app.tor.us/',
     preferred
   }
 }

src/modules/select/wallets/wallet-connect.ts

@@ -30,7 +30,7 @@ function walletConnect(
       provider.autoRefreshOnNetworkChange = false
 
       provider.wc.on('disconnect', () => {
-        resetWalletState({ disconnected: true })
+        resetWalletState({ disconnected: true, walletName: 'WalletConnect' })
       })
 
       return {

src/stores.ts

@@ -77,18 +77,19 @@ export const walletInterface: WalletInterfaceStore = createWalletInterfaceStore(
 )
 
 walletInterface.subscribe((walletInterface: WalletInterface | null) => {
-  if (walletInterface) {
-    const currentState = get(state)
-    // reset state
-    currentState.balance && balance.reset()
-    currentState.address && address.reset()
-    currentState.network && network.reset()
+  // clear all current intervals if they exist
+  currentSyncerIntervals.forEach(
+    (interval: number | undefined) => interval && clearInterval(interval)
+  )
+
+  const currentState = get(state)
 
-    // clear all current intervals if they exist
-    currentSyncerIntervals.forEach(
-      (interval: number | undefined) => interval && clearInterval(interval)
-    )
+  // reset state
+  currentState.balance && balance.reset()
+  currentState.address && address.reset()
+  currentState.network && network.reset()
 
+  if (walletInterface) {
     // start syncing state and save intervals
     currentSyncerIntervals = [
       address.setStateSyncer(walletInterface.address),
@@ -98,33 +99,54 @@ walletInterface.subscribe((walletInterface: WalletInterface | null) => {
   }
 })
 
-export function resetWalletState(options: { disconnected?: boolean } = {}) {
-  // clear all current intervals if they exist
-  currentSyncerIntervals.forEach(
-    (interval: number | undefined) => interval && clearInterval(interval)
-  )
-
+export function resetWalletState(options?: {
+  disconnected: boolean
+  walletName: string
+}) {
   walletInterface.update((currentInterface: WalletInterface | null) => {
-    const { disconnected } = options
-    !disconnected &&
-      currentInterface &&
-      currentInterface.disconnect &&
-      currentInterface.disconnect()
-    return null
-  })
+    // no interface then don't do anything
+    if (!currentInterface) {
+      return currentInterface
+    }
 
-  wallet.update(() => ({
-    name: undefined,
-    provider: undefined,
-    connect: undefined,
-    instance: undefined,
-    url: undefined,
-    loading: undefined
-  }))
+    // no options object, so do a full reset by disconnecting and setting interface to null
+    if (!options) {
+      wallet.update(() => ({
+        name: undefined,
+        provider: undefined,
+        connect: undefined,
+        instance: undefined,
+        url: undefined,
+        loading: undefined
+      }))
+
+      currentInterface.disconnect && currentInterface.disconnect()
+
+      return null
+    }
 
-  balance.reset()
-  address.reset()
-  network.reset()
+    const { walletName, disconnected } = options
+
+    // if walletName is the same as the current interface name then do a full reset (checking if to do a disconnect)
+    if (currentInterface.name === walletName) {
+      wallet.update(() => ({
+        name: undefined,
+        provider: undefined,
+        connect: undefined,
+        instance: undefined,
+        url: undefined,
+        loading: undefined
+      }))
+
+      disconnected &&
+        currentInterface.disconnect &&
+        currentInterface.disconnect()
+
+      return null
+    }
+
+    return currentInterface
+  })
 
   app.update(store => ({
     ...store,
@@ -157,14 +179,13 @@ function createWalletStateSliceStore(options: {
   const { subscribe, set } = writable(initialState)
 
   let currentState: string | number | null | undefined
-  const unsubscribe = subscribe(store => {
+  subscribe(store => {
     currentState = store
   })
 
   return {
     subscribe,
     reset: () => {
-      unsubscribe()
       set(undefined)
     },
     setStateSyncer: (stateSyncer: StateSyncer) => {

src/utilities.ts

@@ -13,7 +13,8 @@ export function getNetwork(provider: any): Promise<number | any> {
       },
       (e: any, res: any) => {
         e && reject(e)
-        resolve(Number(res && res.result))
+        const result = res && res.result
+        resolve(result && Number(result))
       }
     )
   })
@@ -29,7 +30,8 @@ export function getAddress(provider: any): Promise<string | any> {
       },
       (e: any, res: any) => {
         e && reject(e)
-        resolve(res && res.result && res.result[0])
+        const result = res && res.result && res.result[0]
+        resolve(result)
       }
     )
   })
@@ -52,7 +54,8 @@ export function getBalance(provider: any): Promise<string | any> {
       },
       (e: any, res: any) => {
         e && reject(e)
-        resolve(res && res.result && new BigNumber(res.result).toString(10))
+        const result = res && res.result
+        resolve(result && new BigNumber(result).toString(10))
       }
     )
   })
@@ -70,7 +73,7 @@ export function createModernProviderInterface(provider: any): WalletInterface {
             // get the initial value
             getAddress(provider).then(func)
             provider.on('accountsChanged', (accounts: string[]) =>
-              func(accounts[0])
+              func(accounts && accounts[0])
             )
           }
         }
@@ -82,7 +85,9 @@ export function createModernProviderInterface(provider: any): WalletInterface {
           onChange: (func: (val: string | number) => void) => {
             // get initial value
             getNetwork(provider).then(func)
-            provider.on('networkChanged', func)
+            provider.on('networkChanged', (netId: string | number) =>
+              func(netId && Number(netId))
+            )
           }
         }
       : { get: () => getNetwork(provider) },

src/validation.ts

@@ -548,6 +548,7 @@ export function validateWalletInit(
     enableLogging,
     loginMethod,
     showTorusButton,
+    disableNotifications,
     ...otherParams
   } = walletInit
 
@@ -686,4 +687,11 @@ export function validateWalletInit(
     type: 'string',
     optional: true
   })
+
+  validateType({
+    name: 'walletInit.disableNotifications',
+    value: disableNotifications,
+    type: 'boolean',
+    optional: true
+  })
 }