Merge pull request #197 from blocknative/develop

Release 1.2.3

Author: lnbc1QWFyb24

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bnc-onboard",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "Onboard users to web3 by allowing them to select a wallet, get that wallet ready to transact and have access to synced wallet state.",
   "keywords": [
     "ethereum",
@@ -43,7 +43,7 @@
     "@portis/web3": "^2.0.0-beta.42",
     "@toruslabs/torus-embed": "^0.2.11",
     "@walletconnect/web3-provider": "^1.0.0-beta.45",
-    "authereum": "^0.0.4-beta.26",
+    "authereum": "^0.0.4-beta.88",
     "bignumber.js": "^9.0.0",
     "bnc-sdk": "1.0.3",
     "bowser": "^2.5.2",

src/interfaces.ts

@@ -147,11 +147,16 @@ export interface TorusOptions {
   enableLogging?: boolean
 }
 
+export interface AuthereumOptions {
+  disableNotifications?: boolean
+}
+
 export interface WalletInitOptions
   extends CommonWalletOptions,
-    SdkWalletOptions,
-    WalletConnectOptions,
-    TorusOptions {
+  SdkWalletOptions,
+  WalletConnectOptions,
+  TorusOptions,
+  AuthereumOptions {
   walletName: string
 }
 

src/modules/select/wallets/authereum.ts

@@ -1,9 +1,9 @@
 import authereumIcon from '../wallet-icons/icon-authereum.png'
 import { networkName } from '../../../utilities'
-import { WalletModule, CommonWalletOptions } from '../../../interfaces'
+import { WalletModule, AuthereumOptions, CommonWalletOptions } from '../../../interfaces'
 
-function authereum(options: CommonWalletOptions): WalletModule {
-  const { networkId, preferred, label, iconSrc, svg } = options
+function authereum(options: AuthereumOptions & CommonWalletOptions): WalletModule {
+  const { networkId, preferred, label, iconSrc, svg, disableNotifications } = options
 
   return {
     name: label || 'Authereum',
@@ -13,7 +13,7 @@ function authereum(options: CommonWalletOptions): WalletModule {
       const { default: Authereum } = await import('authereum')
       const instance = new Authereum({
         networkName: networkName(networkId),
-        disableNotifications: true
+        disableNotifications: disableNotifications // default: false
       })
 
       const provider = instance.getProvider()
@@ -45,7 +45,7 @@ function authereum(options: CommonWalletOptions): WalletModule {
     },
     desktop: true,
     mobile: true,
-    url: 'https://accounts.authereum.org/',
+    url: `https://${networkId !== 1 ? `${networkName(networkId)}.` : ''}authereum.com/`,
     preferred
   }
 }

src/validation.ts

@@ -529,6 +529,7 @@ export function validateWalletInit(
     enableLogging,
     loginMethod,
     showTorusButton,
+    disableNotifications,
     ...otherParams
   } = walletInit
 
@@ -634,4 +635,10 @@ export function validateWalletInit(
     type: 'boolean',
     optional: true
   })
+  validateType({
+    name: 'walletInit.disableNotifications',
+    value: disableNotifications,
+    type: 'boolean',
+    optional: true
+  })
 }