Version Packages #7579
Version Packages #7579
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update removes a changeset record, increments patch versions for three packages, and adds corresponding changelog entries. The thirdweb package changelog notes a patch for handling multiple fiat currencies in payment widgets and wallet definition updates. No changes were made to code, dependencies, or public APIs; all updates are metadata or documentation. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PaymentWidget
participant FiatCurrencyHandler
User->>PaymentWidget: Initiate payment
PaymentWidget->>FiatCurrencyHandler: Determine supported fiat currencies
FiatCurrencyHandler-->>PaymentWidget: Return available currencies
PaymentWidget-->>User: Display payment options in selected currency
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/thirdweb/package.json (1)
407-407: Missingsize-limitbudget violates repo guideline
packages/*/package.jsonshould declare bundle budgets via a top-levelsize-limitkey so thepnpm sizescript has thresholds to assert against. Consider adding something like:+ "size-limit": [ + { + "path": "dist/esm/exports/thirdweb.js", + "limit": "150 KB" + } + ],This prevents silent growth in future patches.
packages/nebula/package.json (1)
60-60: Add bundle budget tracking
Same guideline applies here: asize-limitentry is missing. Adding one will let CI catch regressions:+ "size-limit": [ + { "path": "dist/esm/exports/thirdweb.js", "limit": "40 KB" } + ],packages/wagmi-adapter/package.json (1)
58-58: Track bundle size budget
Please add asize-limitsection to conform with workspace standards.packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Empty changelog section
## 0.2.110has no notes. Even “No user-visible changes – version bump only” helps future readers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/ready-loops-search.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/ready-loops-search.md
🧰 Additional context used
📓 Path-based instructions (1)
`packages/*/package.json`: Track bundle budgets via `package.json#size-limit` De-duplicate dependencies across packages through pnpm workspace hoisting
packages/*/package.json: Track bundle budgets viapackage.json#size-limit
De-duplicate dependencies across packages through pnpm workspace hoisting
📄 Source: CodeRabbit Inference Engine (CLAUDE.md)
List of files the instruction was applied to:
packages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.json
🧠 Learnings (7)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
packages/wagmi-adapter/package.json (4)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
packages/wagmi-adapter/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
packages/thirdweb/package.json (4)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
packages/nebula/package.json (3)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
packages/nebula/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
packages/thirdweb/CHANGELOG.md (3)
undefined
<retrieved_learning>
Learnt from: gregfromstl
PR: #7450
File: packages/thirdweb/src/bridge/Webhook.ts:57-81
Timestamp: 2025-06-26T19:46:04.024Z
Learning: In the onramp webhook schema (packages/thirdweb/src/bridge/Webhook.ts), the currencyAmount field is intentionally typed as z.number() while other amount fields use z.string() because currencyAmount represents fiat currency amounts in decimals (like $10.50), whereas other amount fields represent token amounts in wei (very large integers that benefit from bigint representation). The different naming convention (currencyAmount vs amount) reflects this intentional distinction.
</retrieved_learning>
<retrieved_learning>
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
</retrieved_learning>
<retrieved_learning>
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to src/wallets/**/*.{ts,tsx} : Support EIP-1193, EIP-5792, EIP-7702 standards in wallet architecture
</retrieved_learning>
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Build Packages
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Unit Tests
- GitHub Check: Analyze (javascript)
🔇 Additional comments (5)
packages/thirdweb/package.json (1)
407-407: Version bump is correct & consistent
Patch increment to5.105.13matches the linked changelog and dependent package bumps.packages/nebula/package.json (1)
60-60: Patch version bump acknowledged
0.2.13correctly reflects the dependency update tothirdweb@5.105.13.packages/wagmi-adapter/package.json (1)
58-58: Version bump looks good
0.2.110is in sync with the changelog entry.packages/nebula/CHANGELOG.md (1)
3-8: Changelog entry is clear and sufficient
Dependency update is documented with hash link – nothing else required.packages/thirdweb/CHANGELOG.md (1)
3-8: Changelog addition looks correct and follows existing conventions — LGTM.
Entry uses the established heading levels, includes the PR link and commit hash, and is placed above the previous version as expected.
size-limit report 📦
|
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
809cde0 to
796626a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7579 +/- ##
=======================================
Coverage 56.49% 56.50%
=======================================
Files 906 906
Lines 58028 58047 +19
Branches 4226 4227 +1
=======================================
+ Hits 32783 32797 +14
- Misses 25137 25140 +3
- Partials 108 110 +2
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nebula@0.2.13
Patch Changes
772eb0c,446a69b]:thirdweb@5.105.13
Patch Changes
#7578
772eb0cThanks @joaquim-verges! - Handle different fiat currencies in payment widgets#7580
446a69bThanks @joaquim-verges! - Update wallet definitions@thirdweb-dev/wagmi-adapter@0.2.110
PR-Codex overview
This PR focuses on updating version numbers across several packages and includes changelogs detailing recent changes and dependency updates.
Detailed summary
.changeset/slimy-zebras-lie.mdand.changeset/ready-loops-search.md.versioninpackages/thirdweb/package.jsonfrom5.105.12to5.105.13.versioninpackages/nebula/package.jsonfrom0.2.12to0.2.13.versioninpackages/wagmi-adapter/package.jsonfrom0.2.109to0.2.110.packages/nebula/CHANGELOG.mdandpackages/thirdweb/CHANGELOG.mddetailing new features and updates.Summary by CodeRabbit