Skip to content

[Dashboard] Add chain, publisher, and contract data to deploy failure analytics #7376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jun 19, 2025

Enhanced Error Reporting for Contract Deployment Failures

Added additional context data to the contract deployment failure analytics by including:

  • chainId: Captures the blockchain network where the deployment failed
  • publisher: Records the contract publisher information
  • contractName: Tracks which contract failed during deployment

These parameters provide more comprehensive error tracking, allowing for better debugging and analysis of deployment failures.

Summary by CodeRabbit

  • New Features
    • Enhanced error reporting for contract deployment failures with additional context, including chain ID, publisher address, and contract name. This provides more detailed feedback when a deployment fails.

Copy link

changeset-bot bot commented Jun 19, 2025

⚠️ No Changeset found

Latest commit: 093572a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 4:03am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 19, 2025 4:03am
login ⬜️ Skipped (Inspect) Jun 19, 2025 4:03am
nebula ⬜️ Skipped (Inspect) Jun 19, 2025 4:03am
thirdweb_playground ⬜️ Skipped (Inspect) Jun 19, 2025 4:03am
wallet-ui ⬜️ Skipped (Inspect) Jun 19, 2025 4:03am

@vercel vercel bot temporarily deployed to Preview – nebula June 19, 2025 03:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 19, 2025 03:55 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 19, 2025 03:55 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 19, 2025 03:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 19, 2025 03:55 Inactive
Copy link
Contributor

coderabbitai bot commented Jun 19, 2025

Walkthrough

The contract deployment failure analytics reporting was enhanced to include additional context: chain ID, publisher, and contract name. The reporting function's signature was updated to accept these new parameters, and the deployment form now supplies these values when reporting a failure.

Changes

File(s) Change Summary
apps/dashboard/src/@/analytics/report.ts Updated reportContractDeployFailed to accept and forward chainId, publisher, and contractName properties.
apps/dashboard/src/components/contract-components/contract-deploy-form/custom-contract.tsx Enhanced error reporting to supply chainId, rewritten publisher, and contractName to the reporting function.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ContractDeployForm
    participant AnalyticsReport

    User->>ContractDeployForm: Submit contract deployment
    ContractDeployForm->>ContractDeployForm: Attempt deployment
    alt Deployment fails
        ContractDeployForm->>AnalyticsReport: reportContractDeployFailed({ errorMessage, chainId, publisher, contractName })
    end
Loading

Possibly related PRs

  • posthog migration: part 4 #7366: Introduces the initial analytics reporting framework and the reportContractDeployed function, which the current PR extends for deployment failure events.

Suggested reviewers

  • MananTank

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1397adf and 093572a.

📒 Files selected for processing (2)
  • apps/dashboard/src/@/analytics/report.ts (1 hunks)
  • apps/dashboard/src/components/contract-components/contract-deploy-form/custom-contract.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Unit Tests
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
apps/dashboard/src/@/analytics/report.ts (1)

38-45: LGTM! Enhanced failure analytics with consistent data structure.

The function signature enhancement is well-designed and maintains consistency with reportContractDeployed. The additional context (chainId, publisher, contractName) will provide valuable insights for deployment failure analysis.

apps/dashboard/src/components/contract-components/contract-deploy-form/custom-contract.tsx (1)

697-702: LGTM! Consistent error reporting with valuable context.

The enhanced error reporting correctly provides the same contextual data as the success case (lines 659-664), using consistent data transformations like rewriteTwPublisher. This will enable comprehensive deployment analytics across both success and failure scenarios.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 19, 2025
Copy link
Member Author

jnsdls commented Jun 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review June 19, 2025 03:56
@jnsdls jnsdls requested review from a team as code owners June 19, 2025 03:56
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.35%. Comparing base (1397adf) to head (093572a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7376   +/-   ##
=======================================
  Coverage   52.35%   52.35%           
=======================================
  Files         939      939           
  Lines       63161    63161           
  Branches     4217     4217           
=======================================
  Hits        33070    33070           
  Misses      29984    29984           
  Partials      107      107           
Flag Coverage Δ
packages 52.35% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.53 KB (0%) 1.3 s (0%) 262 ms (+110.04% 🔺) 1.6 s
thirdweb (cjs) 350.55 KB (0%) 7.1 s (0%) 965 ms (+7.59% 🔺) 8 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 95 ms (+1271.52% 🔺) 209 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 42 ms (+1529.58% 🔺) 53 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 115 ms (+611.75% 🔺) 507 ms

@jnsdls jnsdls merged commit 5492331 into main Jun 19, 2025
28 checks passed
@jnsdls jnsdls deleted the _Dashboard_Add_chain_publisher_and_contract_data_to_deploy_failure_analytics branch June 19, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant