Skip to content

[Dashboard] Rename getMemberById to getMemberByAccountId and add onboarding banner #7334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jun 12, 2025

Rename getMemberById to getMemberByAccountId for clarity

This PR renames the getMemberById function to getMemberByAccountId to better reflect its purpose, as it retrieves team members by their account ID rather than a generic member ID.

Changes:

  • Renamed getMemberById to getMemberByAccountId and updated all references
  • Improved team onboarding flow:
    • Added an onboarding banner for teams created more than 3 days ago
    • Enhanced hasToCompleteTeamOnboarding function to check if user is team owner
  • Updated TeamPlanBadge component to use useDashboardRouter instead of Next.js Link
  • Fixed team onboarding redirect logic to only redirect team owners

These changes improve code clarity and enhance the onboarding experience for team owners.


PR-Codex overview

This PR primarily focuses on refactoring the onboarding logic for team members, specifically changing the way member data is fetched and introducing a new onboarding check for teams.

Detailed summary

  • Renamed getMemberById to getMemberByAccountId for clarity.
  • Updated various components to use the new getMemberByAccountId.
  • Removed the isTeamOnboardingComplete function.
  • Introduced hasToCompleteTeamOnboarding to check onboarding status.
  • Added a banner for teams created over 3 days ago prompting setup completion.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Added an onboarding banner for teams created more than three days ago, encouraging completion of updated setup steps.
  • Refactor

    • Standardized team member retrieval function name and parameters across the app.
    • Enhanced onboarding checks to consider account validation and team member roles.
    • Streamlined navigation and tracking interactions in the team plan badge component.

Copy link

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 11:37pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 12, 2025 11:37pm
login ⬜️ Skipped (Inspect) Jun 12, 2025 11:37pm
thirdweb_playground ⬜️ Skipped (Inspect) Jun 12, 2025 11:37pm
wallet-ui ⬜️ Skipped (Inspect) Jun 12, 2025 11:37pm

@vercel vercel bot temporarily deployed to Preview – login June 12, 2025 22:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 12, 2025 22:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 12, 2025 22:53 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 12, 2025 22:53 Inactive
Copy link

changeset-bot bot commented Jun 12, 2025

⚠️ No Changeset found

Latest commit: 2849782

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 12, 2025

Walkthrough

The changes primarily involve renaming the function getMemberById to getMemberByAccountId across multiple files, updating its parameter and usage accordingly. Additional updates include refactoring onboarding logic to use a new asynchronous function with enhanced checks, adding a conditional onboarding banner, and refactoring the team plan badge component for unified navigation and tracking behavior.

Changes

File(s) Change Summary
apps/dashboard/src/@/api/team-members.ts Renamed getMemberById to getMemberByAccountId, updated parameter name and URL path.
apps/dashboard/src/app/(app)/account/page.tsx
apps/dashboard/src/app/(app)/team/[team_slug]/(team)//settings/billing/page.tsx
apps/dashboard/src/app/(app)/team/[team_slug]/(team)/
/settings/invoices/page.tsx
apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/page.tsx
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/settings/page.tsx
Updated imports and usage from getMemberById to getMemberByAccountId.
apps/dashboard/src/app/(app)/login/onboarding/isOnboardingRequired.ts Removed isTeamOnboardingComplete function; onboarding completion now checked asynchronously with new function.
apps/dashboard/src/app/(app)/team/[team_slug]/layout.tsx Updated onboarding check to use async hasToCompleteTeamOnboarding and refactored concurrent data fetching.
apps/dashboard/src/@/api/team.ts Added new async function hasToCompleteTeamOnboarding that checks account validity, member role, and onboarding status.
apps/dashboard/src/app/(app)/get-started/team/[team_slug]/layout.tsx Added a conditional onboarding banner based on team creation date using new UI components and date logic.
apps/dashboard/src/app/(app)/components/TeamPlanBadge.tsx Refactored badge to always render with onClick handler for navigation and tracking; removed conditional Link wrapper.

Sequence Diagram(s)

Team Member Fetching (After Refactor)

sequenceDiagram
    participant UI
    participant API
    UI->>API: getMemberByAccountId(teamSlug, accountId)
    API-->>UI: Returns member data or null
Loading

Team Onboarding Requirement Check (New Logic)

sequenceDiagram
    participant UI
    participant AccountService
    participant TeamMemberService
    UI->>AccountService: getValidAccount(pagePath)
    AccountService-->>UI: account
    UI->>TeamMemberService: getMemberByAccountId(team.slug, account.id)
    TeamMemberService-->>UI: member
    UI->>UI: Check member existence and role
    UI->>UI: Return onboarding required status based on team.isOnboarded
Loading

TeamPlanBadge Click Handling

sequenceDiagram
    participant User
    participant TeamPlanBadge
    participant Tracker
    participant Router
    User->>TeamPlanBadge: Click badge
    alt Plan is "free"
        TeamPlanBadge->>Tracker: track("ShowPlans")
        TeamPlanBadge->>Router: navigate("/settings/billing")
    else Plan is not "free"
        TeamPlanBadge->>TeamPlanBadge: No navigation
    end
Loading

Possibly related PRs

  • Make free plan badge clickable to upgrade #7134: Refactors the TeamPlanBadge component to add a clickable Link wrapper around the free plan badge and introduces a required teamSlug prop for navigation and tracking; relates to this PR's changes in badge interaction and billing navigation.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 30301d9 and 2849782.

📒 Files selected for processing (11)
  • apps/dashboard/src/@/api/team-members.ts (2 hunks)
  • apps/dashboard/src/@/api/team.ts (2 hunks)
  • apps/dashboard/src/app/(app)/account/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/components/TeamPlanBadge.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/get-started/team/[team_slug]/layout.tsx (3 hunks)
  • apps/dashboard/src/app/(app)/login/onboarding/isOnboardingRequired.ts (0 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/billing/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/invoices/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/settings/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/layout.tsx (3 hunks)
💤 Files with no reviewable changes (1)
  • apps/dashboard/src/app/(app)/login/onboarding/isOnboardingRequired.ts
🚧 Files skipped from review as they are similar to previous changes (10)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/page.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/settings/page.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/invoices/page.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/billing/page.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/layout.tsx
  • apps/dashboard/src/app/(app)/account/page.tsx
  • apps/dashboard/src/app/(app)/get-started/team/[team_slug]/layout.tsx
  • apps/dashboard/src/@/api/team-members.ts
  • apps/dashboard/src/@/api/team.ts
  • apps/dashboard/src/app/(app)/components/TeamPlanBadge.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: Unit Tests
  • GitHub Check: Lint Packages
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 12, 2025
Copy link
Member Author

jnsdls commented Jun 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review June 12, 2025 22:54
@jnsdls jnsdls requested review from a team as code owners June 12, 2025 22:54
@jnsdls jnsdls force-pushed the _Dashboard_Rename_getMemberById_to_getMemberByAccountId_and_add_onboarding_banner branch from fc062de to 1b95215 Compare June 12, 2025 22:54
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 12, 2025 22:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 12, 2025 22:54 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 12, 2025 22:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 12, 2025 22:54 Inactive
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (c152db3) to head (2849782).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7334   +/-   ##
=======================================
  Coverage   55.57%   55.57%           
=======================================
  Files         909      909           
  Lines       58675    58675           
  Branches     4160     4160           
=======================================
  Hits        32609    32609           
  Misses      25959    25959           
  Partials      107      107           
Flag Coverage Δ
packages 55.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 12, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.44 KB (+0.06% 🔺) 1.3 s (+0.06% 🔺) 468 ms (+111.25% 🔺) 1.8 s
thirdweb (cjs) 350.62 KB (0%) 7.1 s (0%) 1.9 s (+1.39% 🔺) 8.9 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 146 ms (+972.38% 🔺) 260 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 29 ms (+544.1% 🔺) 39 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 187 ms (+451.66% 🔺) 579 ms

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🧹 Nitpick comments (6)
apps/dashboard/src/@/api/team-members.ts (1)

51-54: Add an explicit return type for stronger type-safety

getMemberByAccountId currently relies on type inference. Declaring an explicit return type helps TS catch accidental changes (e.g. returning null) and makes the API crystal-clear to consumers.

-export async function getMemberByAccountId(
-  teamSlug: string,
-  accountId: string,
-) {
+export async function getMemberByAccountId(
+  teamSlug: string,
+  accountId: string,
+): Promise<TeamMember | undefined> {
apps/dashboard/src/app/(app)/account/page.tsx (1)

28-28: Potential N-API calls per page load – consider batching

Inside teams.map every team results in its own network call to getMemberByAccountId.
For users in many teams this can create noticeable latency (N + 1 pattern).
If the backend supports it, fetch all memberships in a single call or reuse the list already available in getTeams().

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/settings/page.tsx (1)

40-40: Repeat of the N + 1 membership fetch

Same performance concern as in account/page.tsx: one request per team.
Consider a bulk endpoint or caching getMemberByAccountId results across iterations.

apps/dashboard/src/app/(app)/team/[team_slug]/layout.tsx (1)

33-35: Avoid double account fetch inside hasToCompleteTeamOnboarding

hasToCompleteTeamOnboarding internally calls getValidAccount, incurring an extra cookie read / API hit that this layout doesn’t otherwise need.
Given you already have authToken and could cheaply fetch the account once here, consider passing the account (or member) into the helper to eliminate redundant work on every team page navigation.

No functional bug — just an optional perf tidy-up.

apps/dashboard/src/app/(app)/get-started/team/[team_slug]/layout.tsx (1)

38-41: Guard against clock skew & future-dated createdAt

If team.createdAt is (accidentally) in the future or the server clock differs,
differenceInDays becomes negative and the banner will never render.
A small Math.max(…, 0) keeps intent intact:

-const shouldShowOnboardingBanner =
-  differenceInDays(new Date(), new Date(team.createdAt)) > 3;
+const shouldShowOnboardingBanner =
+  Math.max(differenceInDays(new Date(), new Date(team.createdAt)), 0) > 3;
apps/dashboard/src/app/(app)/login/onboarding/isOnboardingRequired.ts (1)

11-24: Edge-case: getValidAccount can redirect — consider early bailout

getValidAccount may throw a Next.js redirect for unauthenticated users.
Because hasToCompleteTeamOnboarding is itself awaited inside layouts after the auth-token check, the redirect could still bubble up and override the intended “/login” route.

If that’s undesirable, wrap the call and fall back to false:

-  const account = await getValidAccount(pagePath);
+  const account = await getValidAccount(pagePath).catch(() => null);
+  if (!account) {
+    return false;
+  }

Keeps control flow predictable and avoids double redirects.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c152db3 and 1b95215.

📒 Files selected for processing (10)
  • apps/dashboard/src/@/api/team-members.ts (1 hunks)
  • apps/dashboard/src/app/(app)/account/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/components/TeamPlanBadge.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/get-started/team/[team_slug]/layout.tsx (3 hunks)
  • apps/dashboard/src/app/(app)/login/onboarding/isOnboardingRequired.ts (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/billing/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/invoices/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/settings/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/layout.tsx (3 hunks)
🧰 Additional context used
🧠 Learnings (1)
apps/dashboard/src/app/(app)/team/[team_slug]/layout.tsx (1)
Learnt from: jnsdls
PR: thirdweb-dev/js#6929
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/insight/webhooks/page.tsx:14-19
Timestamp: 2025-05-21T05:17:31.283Z
Learning: In Next.js server components, the `params` object can sometimes be a Promise that needs to be awaited, despite type annotations suggesting otherwise. In apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/insight/webhooks/page.tsx, it's necessary to await the params object before accessing its properties.
🧬 Code Graph Analysis (7)
apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/invoices/page.tsx (1)
apps/dashboard/src/@/api/team-members.ts (1)
  • getMemberByAccountId (51-75)
apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/page.tsx (1)
apps/dashboard/src/@/api/team-members.ts (1)
  • getMemberByAccountId (51-75)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/settings/page.tsx (1)
apps/dashboard/src/@/api/team-members.ts (1)
  • getMemberByAccountId (51-75)
apps/dashboard/src/@/api/team-members.ts (2)
apps/dashboard/src/app/(app)/api/lib/getAuthToken.ts (1)
  • getAuthToken (6-14)
apps/dashboard/src/@/constants/public-envs.ts (1)
  • NEXT_PUBLIC_THIRDWEB_API_HOST (21-22)
apps/dashboard/src/app/(app)/team/[team_slug]/layout.tsx (3)
apps/dashboard/src/app/(app)/api/lib/getAuthToken.ts (1)
  • getAuthToken (6-14)
apps/dashboard/src/@/api/team.ts (1)
  • getTeamBySlug (11-30)
apps/dashboard/src/app/(app)/login/onboarding/isOnboardingRequired.ts (1)
  • hasToCompleteTeamOnboarding (11-24)
apps/dashboard/src/app/(app)/account/page.tsx (1)
apps/dashboard/src/@/api/team-members.ts (1)
  • getMemberByAccountId (51-75)
apps/dashboard/src/app/(app)/components/TeamPlanBadge.tsx (1)
apps/dashboard/src/hooks/analytics/useTrack.ts (1)
  • useTrack (13-45)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (5)
apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/invoices/page.tsx (1)

3-3: Import rename looks good

Import path was updated consistently with the new API name. No further action needed.

apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/page.tsx (1)

2-2: Import update acknowledged

The renamed helper is referenced correctly.

apps/dashboard/src/app/(app)/account/page.tsx (1)

2-2: Consistent import rename

No issues here.

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/settings/page.tsx (1)

3-3: Import rename looks correct

Nothing to flag.

apps/dashboard/src/app/(app)/team/[team_slug]/layout.tsx (1)

20-23: Nice micro-optimisation with Promise.all

Fetching the token and the team in parallel shaves one RTT off the critical path.

@jnsdls jnsdls force-pushed the _Dashboard_Rename_getMemberById_to_getMemberByAccountId_and_add_onboarding_banner branch from 1b95215 to c269398 Compare June 12, 2025 22:59
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 12, 2025 22:59 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 12, 2025 22:59 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 12, 2025 22:59 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 12, 2025 22:59 Inactive
@jnsdls jnsdls force-pushed the _Dashboard_Rename_getMemberById_to_getMemberByAccountId_and_add_onboarding_banner branch from c269398 to f0dacda Compare June 12, 2025 23:04
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 12, 2025 23:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 12, 2025 23:04 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 12, 2025 23:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 12, 2025 23:04 Inactive
Copy link

cursor bot commented Jun 12, 2025

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_0bf8c088-9ad0-40ad-bf16-5123b7522382).

@jnsdls jnsdls force-pushed the _Dashboard_Rename_getMemberById_to_getMemberByAccountId_and_add_onboarding_banner branch from f0dacda to 30301d9 Compare June 12, 2025 23:18
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 12, 2025 23:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 12, 2025 23:18 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 12, 2025 23:18 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 12, 2025 23:18 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
apps/dashboard/src/@/api/team.ts (1)

6-6: Use path alias instead of deep relative import for consistency

Every other internal import in this module leverages the @ alias. Falling back to a two-level ../../… path makes the file brittle to directory moves and breaks visual grepping consistency.

-import { getValidAccount } from "../../app/(app)/account/settings/getAccount";
+import { getValidAccount } from "@/app/(app)/account/settings/getAccount";
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f0dacda and 30301d9.

📒 Files selected for processing (11)
  • apps/dashboard/src/@/api/team-members.ts (2 hunks)
  • apps/dashboard/src/@/api/team.ts (2 hunks)
  • apps/dashboard/src/app/(app)/account/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/components/TeamPlanBadge.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/get-started/team/[team_slug]/layout.tsx (3 hunks)
  • apps/dashboard/src/app/(app)/login/onboarding/isOnboardingRequired.ts (0 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/billing/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/invoices/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/settings/page.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/layout.tsx (3 hunks)
💤 Files with no reviewable changes (1)
  • apps/dashboard/src/app/(app)/login/onboarding/isOnboardingRequired.ts
🚧 Files skipped from review as they are similar to previous changes (9)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/invoices/page.tsx
  • apps/dashboard/src/app/(app)/account/page.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/settings/page.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/page.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/layout.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/billing/page.tsx
  • apps/dashboard/src/@/api/team-members.ts
  • apps/dashboard/src/app/(app)/get-started/team/[team_slug]/layout.tsx
  • apps/dashboard/src/app/(app)/components/TeamPlanBadge.tsx
🧰 Additional context used
🧬 Code Graph Analysis (1)
apps/dashboard/src/@/api/team.ts (2)
apps/dashboard/src/app/(app)/account/settings/getAccount.ts (1)
  • getValidAccount (44-53)
apps/dashboard/src/@/api/team-members.ts (1)
  • getMemberByAccountId (51-78)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Lint Packages
  • GitHub Check: Unit Tests
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)

@jnsdls jnsdls force-pushed the _Dashboard_Rename_getMemberById_to_getMemberByAccountId_and_add_onboarding_banner branch from 30301d9 to 2849782 Compare June 12, 2025 23:29
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 12, 2025 23:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 12, 2025 23:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 12, 2025 23:29 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 12, 2025 23:29 Inactive
@jnsdls jnsdls merged commit 680b8cd into main Jun 12, 2025
25 checks passed
@jnsdls jnsdls deleted the _Dashboard_Rename_getMemberById_to_getMemberByAccountId_and_add_onboarding_banner branch June 12, 2025 23:40
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


BugBot free trial expires on June 17, 2025
You have used $0.00 of your $100.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant