Skip to content

Dashboard: Add token selector in asset creation wizard #7132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented May 22, 2025


PR-Codex overview

This PR focuses on enhancing the token management features in a dashboard application, specifically around token creation, distribution, and selection. It introduces new properties and functions to improve user experience and data handling related to tokens.

Detailed summary

  • Added saleTokenAddress to token creation form.
  • Updated TokenSelector to manage selected tokens with improved data handling.
  • Enhanced TokenDistributionFieldset to include a client prop.
  • Modified TokenSaleSection to include currency selection with validation.
  • Introduced onChainUpdated callback in TokenInfoFieldset.
  • Refined token address handling and state management in the payment form.
  • Improved UI elements for better user interaction and feedback.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 22, 2025

⚠️ No Changeset found

Latest commit: 5ab59ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2025 11:23pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 22, 2025 11:23pm
login ⬜️ Skipped (Inspect) May 22, 2025 11:23pm
thirdweb_playground ⬜️ Skipped (Inspect) May 22, 2025 11:23pm
wallet-ui ⬜️ Skipped (Inspect) May 22, 2025 11:23pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui May 22, 2025 22:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 22, 2025 22:33 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 22, 2025 22:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 22, 2025 22:33 Inactive
Copy link

coderabbitai bot commented May 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MananTank MananTank marked this pull request as ready for review May 22, 2025 22:33
@MananTank MananTank requested review from a team as code owners May 22, 2025 22:33
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 22, 2025
Copy link
Member Author

MananTank commented May 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.61%. Comparing base (73629e9) to head (5ab59ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7132   +/-   ##
=======================================
  Coverage   55.61%   55.61%           
=======================================
  Files         902      902           
  Lines       58177    58177           
  Branches     4085     4085           
=======================================
  Hits        32356    32356           
  Misses      25716    25716           
  Partials      105      105           
Flag Coverage Δ
packages 55.61% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 56.62 KB (0%) 1.2 s (0%) 2 s (+14.17% 🔺) 3.1 s
thirdweb (cjs) 309.13 KB (0%) 6.2 s (0%) 14.7 s (+0.1% 🔺) 20.9 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 133 ms (+10.36% 🔺) 247 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 30 ms (-32.02% 🔽) 40 ms
thirdweb/react (minimal + tree-shaking) 19.5 KB (0%) 390 ms (0%) 408 ms (+19.07% 🔺) 798 ms

@MananTank MananTank force-pushed the 05-20-_tool-4531_dashboard_add_token_asset_creation_wizard branch from 7e90eb0 to 24a556b Compare May 22, 2025 22:47
@MananTank MananTank force-pushed the 05-23-dashboard_add_token_selector_in_asset_creation_wizard branch from 43d4488 to 8fe6054 Compare May 22, 2025 22:47
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 22, 2025 22:47 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 22, 2025 22:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 22, 2025 22:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 22, 2025 22:47 Inactive
Copy link
Contributor

graphite-app bot commented May 22, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the token sale functionality within the application. It introduces new properties, refines existing structures, and improves the token selection process to accommodate native tokens and better handle token sales.

### Detailed summary
- Added `saleTokenAddress` to the form validation schema.
- Updated `CreateTokenAssetPage` to handle native token address logic.
- Changed `TokenSelector` to support selected tokens and improved token address handling.
- Enhanced `TokenSaleSection` to include a currency field for token sales.
- Refined state management in `PaymentLinkForm` for better token handling.
- Modified `TokenInfoFieldset` to trigger updates on chain changes.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 05-20-_tool-4531_dashboard_add_token_asset_creation_wizard branch from 24a556b to 73629e9 Compare May 22, 2025 23:15
@graphite-app graphite-app bot force-pushed the 05-23-dashboard_add_token_selector_in_asset_creation_wizard branch from 8fe6054 to 5ab59ff Compare May 22, 2025 23:16
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 22, 2025 23:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 22, 2025 23:16 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 22, 2025 23:16 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 22, 2025 23:16 Inactive
Base automatically changed from 05-20-_tool-4531_dashboard_add_token_asset_creation_wizard to main May 22, 2025 23:23
@graphite-app graphite-app bot merged commit 5ab59ff into main May 22, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 05-23-dashboard_add_token_selector_in_asset_creation_wizard branch May 22, 2025 23:24
@vercel vercel bot temporarily deployed to Production – docs-v2 May 22, 2025 23:24 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 22, 2025 23:24 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 22, 2025 23:24 Inactive
@vercel vercel bot temporarily deployed to Production – login May 22, 2025 23:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants