-
Notifications
You must be signed in to change notification settings - Fork 535
Dashboard: Add token selector in asset creation wizard #7132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Add token selector in asset creation wizard #7132
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7132 +/- ##
=======================================
Coverage 55.61% 55.61%
=======================================
Files 902 902
Lines 58177 58177
Branches 4085 4085
=======================================
Hits 32356 32356
Misses 25716 25716
Partials 105 105
🚀 New features to boost your workflow:
|
size-limit report 📦
|
7e90eb0
to
24a556b
Compare
43d4488
to
8fe6054
Compare
Merge activity
|
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the token sale functionality within the application. It introduces new properties, refines existing structures, and improves the token selection process to accommodate native tokens and better handle token sales. ### Detailed summary - Added `saleTokenAddress` to the form validation schema. - Updated `CreateTokenAssetPage` to handle native token address logic. - Changed `TokenSelector` to support selected tokens and improved token address handling. - Enhanced `TokenSaleSection` to include a currency field for token sales. - Refined state management in `PaymentLinkForm` for better token handling. - Modified `TokenInfoFieldset` to trigger updates on chain changes. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
24a556b
to
73629e9
Compare
8fe6054
to
5ab59ff
Compare
PR-Codex overview
This PR focuses on enhancing the token management features in a dashboard application, specifically around token creation, distribution, and selection. It introduces new properties and functions to improve user experience and data handling related to tokens.
Detailed summary
saleTokenAddress
to token creation form.TokenSelector
to manage selected tokens with improved data handling.TokenDistributionFieldset
to include aclient
prop.TokenSaleSection
to include currency selection with validation.onChainUpdated
callback inTokenInfoFieldset
.