Remove advancedEnabled field from Account interface #7118

jnsdls · 2025-05-21T23:13:31Z

TL;DR

Removed the advancedEnabled property from the Account type and cleaned up a TODO comment.

What changed?

Removed the advancedEnabled boolean property from the Account type definition in useApi.ts
Removed a TODO comment about adding image URL in the Account type
Updated the newAccountStub function in stubs.ts to remove the advancedEnabled property from the default account stub

How to test?

Verify that any components or functions using the Account type don't reference the removed advancedEnabled property
Check that the account stub is properly created without the advancedEnabled property
Ensure that any UI components that previously used this property are updated accordingly

Why make this change?

The advancedEnabled property is no longer needed in the Account type, likely because this feature flag has been deprecated or the functionality has been restructured. Removing unused properties keeps the codebase clean and prevents confusion about which fields are actually used.

Summary by CodeRabbit

Refactor
- Removed the "advancedEnabled" property from account-related data. This change does not affect user-facing features or functionality.

vercel · 2025-05-21T23:13:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 21, 2025 11:21pm

4 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	May 21, 2025 11:21pm
login	⬜️ Skipped (Inspect)	May 21, 2025 11:21pm
thirdweb_playground	⬜️ Skipped (Inspect)	May 21, 2025 11:21pm
wallet-ui	⬜️ Skipped (Inspect)	May 21, 2025 11:21pm

changeset-bot · 2025-05-21T23:13:35Z

⚠️ No Changeset found

Latest commit: 227ebc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-05-21T23:13:38Z

Walkthrough

The changes remove the advancedEnabled property from the Account type definition and eliminate its usage in a related stub function. No other type or logic modifications were made, and no changes occurred to exported function signatures.

Changes

File(s)	Change Summary
apps/dashboard/src/@3rdweb-sdk/react/hooks/useApi.ts	Removed advancedEnabled property from the Account type definition and deleted a related commented TODO line.
apps/dashboard/src/stories/stubs.ts	Removed advancedEnabled property from the object returned by newAccountStub. No changes to function signature.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c3a8d3 and 227ebc8.

📒 Files selected for processing (2)

apps/dashboard/src/@3rdweb-sdk/react/hooks/useApi.ts (0 hunks)
apps/dashboard/src/stories/stubs.ts (0 hunks)

💤 Files with no reviewable changes (2)

apps/dashboard/src/stories/stubs.ts
apps/dashboard/src/@3rdweb-sdk/react/hooks/useApi.ts

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: Unit Tests
GitHub Check: Lint Packages
GitHub Check: Size
GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Analyze (javascript)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

jnsdls · 2025-05-21T23:13:46Z

Remove advancedEnabled field from Account interface #7118 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2025-05-21T23:16:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.59%. Comparing base (6c3a8d3) to head (227ebc8).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7118   +/-   ##
=======================================
  Coverage   55.59%   55.59%           
=======================================
  Files         901      901           
  Lines       58121    58121           
  Branches     4068     4068           
=======================================
  Hits        32315    32315           
  Misses      25701    25701           
  Partials      105      105

Flag	Coverage Δ
packages	`55.59% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-05-21T23:18:08Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	56.57 KB (0%)	1.2 s (0%)	234 ms (+136.44% 🔺)	1.4 s
thirdweb (cjs)	309.52 KB (0%)	6.2 s (0%)	869 ms (+7.05% 🔺)	7.1 s
thirdweb (minimal + tree-shaking)	5.69 KB (0%)	114 ms (0%)	77 ms (+886.44% 🔺)	191 ms
thirdweb/chains (tree-shaking)	531 B (0%)	11 ms (0%)	13 ms (+337.42% 🔺)	23 ms
thirdweb/react (minimal + tree-shaking)	19.5 KB (0%)	390 ms (0%)	91 ms (+497.17% 🔺)	481 ms

Remove advancedEnabled field from Account interface

227ebc8

vercel bot temporarily deployed to Preview – login May 21, 2025 23:13 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground May 21, 2025 23:13 Inactive

vercel bot temporarily deployed to Preview – docs-v2 May 21, 2025 23:13 Inactive

vercel bot temporarily deployed to Preview – wallet-ui May 21, 2025 23:13 Inactive

github-actions bot assigned jnsdls May 21, 2025

github-actions bot added the Dashboard Involves changes to the Dashboard. label May 21, 2025

jnsdls marked this pull request as ready for review May 21, 2025 23:13

jnsdls requested review from a team as code owners May 21, 2025 23:13

jnsdls merged commit 88533d9 into main May 21, 2025
25 of 26 checks passed

jnsdls deleted the Remove_advancedEnabled_field_from_Account_interface branch May 21, 2025 23:16

vercel bot deployed to Preview – thirdweb-www May 21, 2025 23:21 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove advancedEnabled field from Account interface #7118

Remove advancedEnabled field from Account interface #7118

jnsdls commented May 21, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented May 21, 2025 •

edited

Loading

changeset-bot bot commented May 21, 2025

coderabbitai bot commented May 21, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

jnsdls commented May 21, 2025

codecov bot commented May 21, 2025 •

edited

Loading

github-actions bot commented May 21, 2025

Remove advancedEnabled field from Account interface #7118

Remove advancedEnabled field from Account interface #7118

Conversation

jnsdls commented May 21, 2025 • edited by coderabbitai bot Loading

TL;DR

What changed?

How to test?

Why make this change?

Summary by CodeRabbit

vercel bot commented May 21, 2025 • edited Loading

changeset-bot bot commented May 21, 2025

⚠️ No Changeset found

coderabbitai bot commented May 21, 2025 • edited Loading

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

jnsdls commented May 21, 2025

How to use the Graphite Merge Queue

codecov bot commented May 21, 2025 • edited Loading

Codecov Report

github-actions bot commented May 21, 2025

size-limit report 📦

jnsdls commented May 21, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented May 21, 2025 •

edited

Loading

coderabbitai bot commented May 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented May 21, 2025 •

edited

Loading