Skip to content

[NEB-241] Nebula: /chat endpoint schema update related changes #6982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented May 8, 2025


PR-Codex overview

This PR focuses on refactoring the messaging system in the nebula-app, transitioning from a simple string-based message structure to a more complex object-based structure. This includes changes to how messages are sent, stored, and displayed.

Detailed summary

  • Updated message structure to support multiple content types (text, image, transaction).
  • Changed the sendMessage function to accept NebulaUserMessage objects instead of strings.
  • Modified components to handle the new message structure, including Chats, ChatBar, and FloatingChatContent.
  • Adjusted message rendering logic to differentiate between content types.
  • Enhanced type definitions in types.ts for better clarity and type safety.
  • Updated story files to reflect changes in message structure for testing.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 5:11pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 9, 2025 5:11pm
login ⬜️ Skipped (Inspect) May 9, 2025 5:11pm
thirdweb_playground ⬜️ Skipped (Inspect) May 9, 2025 5:11pm
wallet-ui ⬜️ Skipped (Inspect) May 9, 2025 5:11pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui May 8, 2025 20:33 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 8, 2025 20:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 8, 2025 20:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 8, 2025 20:33 Inactive
Copy link

linear bot commented May 8, 2025

Copy link

changeset-bot bot commented May 8, 2025

⚠️ No Changeset found

Latest commit: 7ae3a81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review May 8, 2025 20:33
@MananTank MananTank requested review from a team as code owners May 8, 2025 20:33
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 8, 2025
Copy link
Member Author

MananTank commented May 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title [NEB-241] Dashboard: /chat endpoint schema update related changes [NEB-241] Nebula: /chat endpoint schema update related changes May 8, 2025
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 8, 2025 20:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 8, 2025 20:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 8, 2025 20:34 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 8, 2025 20:34 Inactive
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.60%. Comparing base (ccb9cd5) to head (7ae3a81).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6982   +/-   ##
=======================================
  Coverage   54.60%   54.60%           
=======================================
  Files         903      903           
  Lines       57934    57934           
  Branches     3970     3970           
=======================================
  Hits        31632    31632           
  Misses      26202    26202           
  Partials      100      100           
Flag Coverage Δ
packages 54.60% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 8, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.17 KB (0%) 1.1 s (0%) 193 ms (+156.32% 🔺) 1.3 s
thirdweb (cjs) 193.88 KB (0%) 3.9 s (0%) 364 ms (+36.19% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 79 ms (+1487.57% 🔺) 193 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 36 ms (+2003.56% 🔺) 46 ms
thirdweb/react (minimal + tree-shaking) 19.51 KB (0%) 391 ms (0%) 97 ms (+730.7% 🔺) 487 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui May 8, 2025 20:45 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 8, 2025 20:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 8, 2025 20:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 8, 2025 20:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 16:32 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 16:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 16:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 16:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 16:49 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 16:49 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 16:49 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 16:49 Inactive
Copy link
Contributor

graphite-app bot commented May 9, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the message structure in the chat components to utilize a new `NebulaUserMessage` type, enhancing the way messages are handled and displayed throughout the application.

### Detailed summary
- Updated message structure in `Chats` and `ChatBar` to use `NebulaUserMessage`.
- Changed message content handling in `FloatingChatContent` and `ChatPageContent`.
- Modified `NebulaImage` component to accept new props.
- Adjusted `EmptyStateChatPageContent` and `Chats` to support new message format.
- Enhanced message rendering logic in `RenderMessage` and `RenderResponse` components.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 17:03 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 17:03 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 17:03 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 17:03 Inactive
@graphite-app graphite-app bot merged commit 7ae3a81 into main May 9, 2025
23 checks passed
@graphite-app graphite-app bot deleted the neb-241 branch May 9, 2025 17:11
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 9, 2025 17:11 Inactive
@vercel vercel bot temporarily deployed to Production – login May 9, 2025 17:11 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 May 9, 2025 17:11 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 9, 2025 17:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants