Skip to content

[Dashboard] Add Indonesia to SMS country select options #6978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 8, 2025


PR-Codex overview

This PR adds support for Indonesia in the countryPrefixes and countryNames records, enhancing the sms-country-select utility in the embedded wallet configuration.

Detailed summary

  • Added entry for ID with value "Indonesia" in the countryNames record.
  • Added entry for ID with value "+62" in the countryPrefixes record.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – wallet-ui May 8, 2025 08:29 Inactive
Copy link

vercel bot commented May 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 8:36am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 8, 2025 8:36am
login ⬜️ Skipped (Inspect) May 8, 2025 8:36am
thirdweb_playground ⬜️ Skipped (Inspect) May 8, 2025 8:36am
wallet-ui ⬜️ Skipped (Inspect) May 8, 2025 8:36am

@vercel vercel bot temporarily deployed to Preview – docs-v2 May 8, 2025 08:29 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 8, 2025 08:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 8, 2025 08:29 Inactive
Copy link

changeset-bot bot commented May 8, 2025

⚠️ No Changeset found

Latest commit: da21d8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 8, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review May 8, 2025 08:29
@joaquim-verges joaquim-verges requested review from a team as code owners May 8, 2025 08:29
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.59%. Comparing base (a5a1d17) to head (da21d8b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6978   +/-   ##
=======================================
  Coverage   54.59%   54.59%           
=======================================
  Files         903      903           
  Lines       57930    57930           
  Branches     3971     3971           
=======================================
  Hits        31627    31627           
  Misses      26202    26202           
  Partials      101      101           
Flag Coverage Δ
packages 54.59% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 8, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.12 KB (0%) 1.1 s (0%) 275 ms (+313.38% 🔺) 1.4 s
thirdweb (cjs) 193.8 KB (0%) 3.9 s (0%) 445 ms (+51.97% 🔺) 4.4 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 115 ms (+1354.19% 🔺) 229 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 27 ms (+1321.99% 🔺) 37 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 112 ms (+781.72% 🔺) 503 ms

@joaquim-verges joaquim-verges merged commit 99d2497 into main May 8, 2025
26 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_Add_Indonesia_to_SMS_country_select_options branch May 8, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant