Skip to content

Nk assets creation #6922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Nk assets creation #6922

wants to merge 19 commits into from

Conversation

pinkhoodie
Copy link
Contributor

@pinkhoodie pinkhoodie commented May 2, 2025


PR-Codex overview

This PR focuses on enhancing the asset management features in the dashboard application, including the creation and import of tokens and NFTs, as well as improvements to the sidebar layout and step indicators for user navigation.

Detailed summary

  • Added Layout component to render children.
  • Introduced CoinsIcon in ProjectSidebarLayout.
  • Added "Assets" link in the sidebar.
  • Enhanced RenderSidebarGroup with unique keys for separators.
  • Created ImportAssetPage with multi-step form for asset import.
  • Developed AssetsPage for asset management overview and creation.
  • Implemented CreateNFTPage for NFT collection creation with step indicators.
  • Created CreateTokenPage for ERC20 token deployment with advanced options.
  • Added CSV upload functionality for airdrop addresses.

The following files were skipped due to too many changes: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/assets/create-token/page.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: 6755e1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 3:52am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 10, 2025 3:52am
login ⬜️ Skipped (Inspect) May 10, 2025 3:52am
thirdweb_playground ⬜️ Skipped (Inspect) May 10, 2025 3:52am
wallet-ui ⬜️ Skipped (Inspect) May 10, 2025 3:52am

Copy link
Contributor

graphite-app bot commented May 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 326 ms (+97.86% 🔺) 1.5 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 754 ms (+34.31% 🔺) 4.7 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 88 ms (+811.75% 🔺) 202 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 36 ms (+1059.68% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 19.55 KB (0%) 391 ms (0%) 158 ms (+535.85% 🔺) 549 ms

Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.59%. Comparing base (ec50f8c) to head (1ff19af).
Report is 120 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6922      +/-   ##
==========================================
- Coverage   55.02%   54.59%   -0.43%     
==========================================
  Files         898      903       +5     
  Lines       57352    57935     +583     
  Branches     3969     3970       +1     
==========================================
+ Hits        31560    31632      +72     
- Misses      25692    26202     +510     
- Partials      100      101       +1     
Flag Coverage Δ
packages 54.59% <ø> (-0.43%) ⬇️

see 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 18:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 18:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 6, 2025 18:15 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 18:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 6, 2025 22:50 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 22:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 22:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 22:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 22:51 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 6, 2025 22:51 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 22:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 22:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 7, 2025 14:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 20:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 20:44 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 20:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 20:58 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 20:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 20:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 10, 2025 03:18 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 10, 2025 03:18 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 10, 2025 03:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 10, 2025 03:18 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 10, 2025 03:36 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 10, 2025 03:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 10, 2025 03:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 10, 2025 03:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 10, 2025 03:46 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 10, 2025 03:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 10, 2025 03:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 10, 2025 03:46 Inactive
Copy link
Contributor

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

@github-actions github-actions bot added the Stale label May 18, 2025
@github-actions github-actions bot closed this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants