Skip to content

Improve .NET/Unity Documentation #6438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Mar 7, 2025

Also adds Insight and Engine
Closes TOOL-3570


PR-Codex overview

This PR focuses on updating documentation and sidebar navigation for the Thirdweb .NET SDK, enhancing clarity and organization, and introducing new features related to EngineWallet and ThirdwebInsight.

Detailed summary

  • Updated title in page.mdx for ThirdwebNebula.
  • Added a description for EngineWallet with usage examples.
  • Introduced ThirdwebInsight with examples for blockchain data queries.
  • Modified sidebar links, added separators, and reorganized sections for better navigation.
  • Removed Constants.DECIMALS_18 from utils documentation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper requested review from a team as code owners March 7, 2025 22:16
Copy link

linear bot commented Mar 7, 2025

Copy link

changeset-bot bot commented Mar 7, 2025

⚠️ No Changeset found

Latest commit: 1c135b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 10:33pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Mar 7, 2025 10:33pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 7, 2025 10:33pm
thirdweb-www ⬜️ Skipped (Inspect) Mar 7, 2025 10:33pm
wallet-ui ⬜️ Skipped (Inspect) Mar 7, 2025 10:33pm

Copy link
Contributor

graphite-app bot commented Mar 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Mar 7, 2025
@0xFirekeeper 0xFirekeeper added the merge-queue Adds the pull request to Graphite's merge queue. label Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.64%. Comparing base (286114a) to head (1c135b0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6438   +/-   ##
=======================================
  Coverage   54.64%   54.64%           
=======================================
  Files         874      874           
  Lines       54708    54708           
  Branches     3707     3707           
=======================================
  Hits        29896    29896           
  Misses      24717    24717           
  Partials       95       95           
Flag Coverage Δ
packages 54.64% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member Author

0xFirekeeper commented Mar 7, 2025

Merge activity

  • Mar 7, 5:19 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 7, 5:25 PM EST: A user added this pull request to the Graphite merge queue.
  • Mar 7, 5:34 PM EST: A user merged this pull request with the Graphite merge queue.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 245 ms (+120.92% 🔺) 1.2 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 399 ms (+27.85% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 90 ms (+804.72% 🔺) 202 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 22 ms (+211.82% 🔺) 32 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 124 ms (+359.3% 🔺) 511 ms

Also adds Insight and Engine
Closes TOOL-3570

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing documentation and sidebar navigation for the Thirdweb .NET SDK, introducing new wallet integrations, and updating metadata and descriptions for clarity.

### Detailed summary
- Updated `PrivateKeyWallet` description to markdown format.
- Changed `title` in `nebula/quickstart` metadata.
- Added utility functions description in `utils/page.mdx`.
- Removed `Constants.DECIMALS_18`.
- Added `EngineWallet` documentation with usage example.
- Updated sidebar links for better organization and added new sections.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the firekeeper/insight-engine-dotnet branch from 0d7ab4f to 1c135b0 Compare March 7, 2025 22:26
@vercel vercel bot temporarily deployed to Preview – login March 7, 2025 22:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 7, 2025 22:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 7, 2025 22:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 7, 2025 22:26 Inactive
@graphite-app graphite-app bot merged commit 1c135b0 into main Mar 7, 2025
32 checks passed
@graphite-app graphite-app bot deleted the firekeeper/insight-engine-dotnet branch March 7, 2025 22:34
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Mar 7, 2025
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 7, 2025 22:34 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui March 7, 2025 22:34 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www March 7, 2025 22:34 Inactive
@vercel vercel bot temporarily deployed to Production – login March 7, 2025 22:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants