Deprecate Service::add_client

Somehow this is going backward: such methods that establish a
bi-directional connection between two actors are more than convenient.
However, this method was too specialized and only used by an example.

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>

Author: didier-wenzek

crates/core/tedge_actors/src/examples/mod.rs

@@ -43,7 +43,7 @@
 //! to establish appropriate connections between the actor message boxes.
 //!
 //! ```
-//! # use tedge_actors::{Actor, Builder, ChannelError, MessageReceiver, Sender, NoConfig, ServerActor, ServerMessageBox, ServerMessageBoxBuilder, SimpleMessageBox, SimpleMessageBoxBuilder, Service, MessageSink};
+//! # use tedge_actors::{Actor, Builder, ChannelError, MessageReceiver, Sender, NoConfig, ServerActor, ServerMessageBox, ServerMessageBoxBuilder, SimpleMessageBox, SimpleMessageBoxBuilder, Service, MessageSink, MessageSource};
 //! # use crate::tedge_actors::examples::calculator_server::*;
 //! # #[tokio::main]
 //! # async fn main_test() -> Result<(),ChannelError> {
@@ -60,12 +60,14 @@
 //! // Connecting the two boxes, so the box built by the `player_box_builder`:
 //! // - receives as input, the output messages sent from the server message box
 //! // - sends output messages to the server message box as its input.
-//! server_box_builder.add_client(&mut player_1_box_builder);
+//! let request_sender = server_box_builder.add_requester(player_1_box_builder.get_sender());
+//! player_1_box_builder.register_peer(NoConfig, request_sender);
 //!
 //! // It matters that the builder of the server box is a `ServerMessageBoxBuilder`:
 //! // as this builder accepts multiple client actors to connect to the same server.
 //! let mut player_2_box_builder = SimpleMessageBoxBuilder::new("Player 2", 1);
-//! server_box_builder.add_client(&mut player_2_box_builder);
+//! let request_sender = server_box_builder.add_requester(player_2_box_builder.get_sender());
+//! player_2_box_builder.register_peer(NoConfig, request_sender);
 //!
 //! // One can then build the message boxes
 //! let server_box: ServerMessageBox<Operation,Update> = server_box_builder.build();

crates/core/tedge_actors/src/servers/mod.rs

@@ -101,8 +101,6 @@ use std::fmt::Debug;
 use crate::DynSender;
 use crate::Message;
 use crate::MessageSink;
-use crate::MessageSource;
-use crate::NoConfig;
 use crate::Sender;
 use async_trait::async_trait;
 
@@ -150,11 +148,6 @@ pub trait Service<Request: Message, Response: Message>:
 {
     /// Connect a request message box to the server box under construction
     fn add_requester(&mut self, response_sender: DynSender<Response>) -> DynSender<Request>;
-
-    fn add_client(
-        &mut self,
-        client: &mut (impl MessageSource<Request, NoConfig> + MessageSink<Response>),
-    );
 }
 
 impl<T, Request: Message, Response: Message> Service<Request, Response> for T
@@ -168,12 +161,4 @@ where
         };
         request_sender.into()
     }
-
-    fn add_client(
-        &mut self,
-        client: &mut (impl MessageSource<Request, NoConfig> + MessageSink<Response>),
-    ) {
-        let request_sender = self.add_requester(client.get_sender());
-        client.register_peer(NoConfig, request_sender);
-    }
 }