Deprecate DynRequestSender type alias

The idea is to reduce the number of concepts.

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>

Author: didier-wenzek

crates/core/tedge_actors/src/builders.rs

@@ -177,7 +177,7 @@ pub trait MessageSink<M: Message> {
 /// The [Builder] of an [Actor](crate::Actor) must implement this trait
 /// for every message type that actor can send to its peers.
 ///
-/// To receive messages from a `MessageSource<M, C>`, the peer must be a `MessageSink<M>`.
+/// To receive messages from a `MessageSource<M, C>`, the peer must be a `MessageSink<From<M>`.
 pub trait MessageSource<M: Message, Config> {
     /// The message will be sent to the peer using the provided `sender`
     fn register_peer(&mut self, config: Config, sender: DynSender<M>);

crates/core/tedge_actors/src/servers/builders.rs

@@ -4,7 +4,6 @@ use crate::Builder;
 use crate::CloneSender;
 use crate::ConcurrentServerActor;
 use crate::ConcurrentServerMessageBox;
-use crate::DynRequestSender;
 use crate::DynSender;
 use crate::LoggingReceiver;
 use crate::Message;
@@ -52,7 +51,7 @@ impl<Request: Message, Response: Message> ServerMessageBoxBuilder<Request, Respo
     }
 
     /// Return a sender for the requests
-    pub fn request_sender(&self) -> DynRequestSender<Request, Response> {
+    pub fn request_sender(&self) -> DynSender<RequestEnvelope<Request, Response>> {
         self.request_sender.sender_clone()
     }
 
@@ -134,7 +133,7 @@ impl<S: Server, K> ServerActorBuilder<S, K> {
     }
 
     /// Return a sender for the requests
-    pub fn request_sender(&self) -> DynRequestSender<S::Request, S::Response> {
+    pub fn request_sender(&self) -> DynSender<RequestEnvelope<S::Request, S::Response>> {
         self.box_builder.request_sender()
     }
 }

crates/core/tedge_actors/src/servers/mod.rs

@@ -144,9 +144,6 @@ impl<Request, Response> AsRef<Request> for RequestEnvelope<Request, Response> {
     }
 }
 
-/// A request sender to some [Server]
-pub type DynRequestSender<Request, Response> = DynSender<RequestEnvelope<Request, Response>>;
-
 /// A connector to a [Server] expecting Request and returning Response.
 pub trait Service<Request: Message, Response: Message>:
     MessageSink<RequestEnvelope<Request, Response>>

crates/core/tedge_actors/src/test_helpers.rs

@@ -2,7 +2,6 @@
 use crate::Builder;
 use crate::ChannelError;
 use crate::CloneSender;
-use crate::DynRequestSender;
 use crate::DynSender;
 use crate::Message;
 use crate::MessageReceiver;
@@ -662,7 +661,7 @@ pub trait ServiceProviderExt<I: Message, O: Message> {
     fn new_client_box(&mut self) -> SimpleMessageBox<O, I>;
 }
 
-impl<I: Message, O: Message> ServiceProviderExt<I, O> for DynRequestSender<I, O> {
+impl<I: Message, O: Message> ServiceProviderExt<I, O> for DynSender<RequestEnvelope<I, O>> {
     fn new_client_box(&mut self) -> SimpleMessageBox<O, I> {
         let name = "client-box";
         let capacity = 16;

crates/core/tedge_actors/src/tests.rs

@@ -27,7 +27,7 @@ impl Server for SleepService {
     }
 }
 
-async fn spawn_sleep_service() -> DynRequestSender<u64, u64> {
+async fn spawn_sleep_service() -> DynSender<RequestEnvelope<u64, u64>> {
     let config = ServerConfig::default();
     let actor = ServerActorBuilder::new(SleepService, &config, Sequential);
     let handle = actor.request_sender();
@@ -37,7 +37,9 @@ async fn spawn_sleep_service() -> DynRequestSender<u64, u64> {
     handle
 }
 
-async fn spawn_concurrent_sleep_service(max_concurrency: usize) -> DynRequestSender<u64, u64> {
+async fn spawn_concurrent_sleep_service(
+    max_concurrency: usize,
+) -> DynSender<RequestEnvelope<u64, u64>> {
     let config = ServerConfig::default().with_max_concurrency(max_concurrency);
     let actor = ServerActorBuilder::new(SleepService, &config, Concurrent);
     let handle = actor.request_sender();