Skip to content

Update NPM packages, Hugo to 0.147.6 #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jun 7, 2025

  • Updates of NPM packages, Hugo in particular
    • With this Hugo update, URL encodings are fixed. For example, ampersands are encoded as & in hrefs
  • Adjustment to render-hook template access
  • Updates refcache.json
  • Drops unnecessary query param on an (old) new URL
  • (Docsy update will be due after this PR.)

@chalin chalin added the CI/infra CI & infrastructure label Jun 7, 2025
lukpueh
lukpueh previously approved these changes Jun 10, 2025
@lukpueh lukpueh dismissed their stale review June 10, 2025 07:24

Needs re-review

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview deployment shows a bunch of errors on the JS console: https://deploy-preview-123--theupdateframework.netlify.app/

Are they caused by this patch? Among other things, it cannot load the background image (which, IMO, makes the site look better, but that's an unrelated concern).

Signed-off-by: Patrice Chalin <pchalin@gmail.com>
@chalin
Copy link
Collaborator Author

chalin commented Jun 10, 2025

Preview deployment shows a bunch of errors on the JS console: https://deploy-preview-123--theupdateframework.netlify.app/

Are they caused by this patch? Among other things, it cannot load the background image

Thanks for catching that. Fixed via 4c1da47. PTAL

As for the other console errors, they are expected, because the generated site files has embedded style etc, that the CSP rules don't permit.

(which, IMO, makes the site look better, but that's an unrelated concern).

😄 Feel free to file an issue and cc me.

@chalin
Copy link
Collaborator Author

chalin commented Jun 10, 2025

😄 Feel free to file an issue and cc me.

I decided to create the issue. Here it is:

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukpueh lukpueh merged commit af407b3 into theupdateframework:main Jun 11, 2025
7 checks passed
@chalin chalin deleted the chalin-im-fix-format-etc-2025-06-07 branch June 13, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants