Skip to content

change linkClasses in FwbNavbarLink to be computed rather than only evaluated on mount to resolve #373 #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

change linkClasses in FwbNavbarLink to be computed rather than only evaluated on mount to resolve #373 #375

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd21545
fix: change linkClasses in FwbNavbarLink to be computed rather than o…
thepurpleblob Apr 25, 2025
9de4614
fix linter errors
Sqrcz Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/FwbNavbar/FwbNavbarLink.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,12 @@
const componentName = computed(() => {
return props.component !== 'a' ? resolveComponent(props.component) : 'a'
})
const linkClasses = twMerge(
defaultClasses,
props.isActive ? currentPageClasses : defaultStateClasses,
)
const linkClasses = computed(() => {
return twMerge(

Check failure on line 41 in src/components/FwbNavbar/FwbNavbarLink.vue

View workflow job for this annotation

GitHub Actions / lint (18.x) 

Expected indentation of 2 spaces but found 4
defaultClasses,

Check failure on line 42 in src/components/FwbNavbar/FwbNavbarLink.vue

View workflow job for this annotation

GitHub Actions / lint (18.x) 

Expected indentation of 4 spaces but found 8
props.isActive ? currentPageClasses: defaultStateClasses,

Check failure on line 43 in src/components/FwbNavbar/FwbNavbarLink.vue

View workflow job for this annotation

GitHub Actions / lint (18.x) 

Operator ':' must be spaced

Check failure on line 43 in src/components/FwbNavbar/FwbNavbarLink.vue

View workflow job for this annotation

GitHub Actions / lint (18.x) 

Expected indentation of 4 spaces but found 1 tab

Check failure on line 43 in src/components/FwbNavbar/FwbNavbarLink.vue

View workflow job for this annotation

GitHub Actions / lint (18.x) 

Unexpected tab character
)

Check failure on line 44 in src/components/FwbNavbar/FwbNavbarLink.vue

View workflow job for this annotation

GitHub Actions / lint (18.x) 

Expected indentation of 2 spaces but found 4
})
const handleClick = (event: Event) => {
if (props.disabled) {
return
Expand Down
Loading