Skip to content

Fixed the icon placeholder position in FwbAvatar #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Fixed the icon placeholder position in FwbAvatar #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/FwbAvatar/FwbAvatar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</div>
<svg
v-else-if="!img && !initials"
:class="avatarPlaceholderClasses"
:class="avatarPlaceholderIconClasses"
fill="currentColor"
viewBox="0 0 20 20"
xmlns="http://www.w3.org/2000/svg"
Expand Down Expand Up @@ -103,6 +103,7 @@ const {
avatarClasses,
avatarDotClasses,
avatarPlaceholderClasses,
avatarPlaceholderIconClasses,
avatarPlaceholderInitialsClasses,
avatarPlaceholderWrapperClasses,
} = useAvatarClasses(toRefs(props))
Expand Down
13 changes: 12 additions & 1 deletion src/components/FwbAvatar/composables/useAvatarClasses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ const avatarStatusDotPositionClasses: Record<avatarDotIndicatorPositionClasses,
'bottom-left-default': '-bottom-1.5 left-0 transform -translate-x-1/2 ',
}

const avatarPlaceholderDefaultClasses = 'absolute w-auto h-auto text-gray-400'
const avatarPlaceholderDefaultClasses = 'w-auto h-auto text-gray-400'
const avatarPlaceholderDefaultIconClasses = 'absolute'
const avatarPlaceholderWrapperDefaultClasses = 'flex overflow-hidden relative justify-center items-center'
const avatarPlaceholderWrapperBackgroundClasses = 'bg-gray-100 dark:bg-gray-600'
const avatarPlaceholderInitialsDefaultClasses = 'font-medium text-gray-600 dark:text-gray-300'
Expand All @@ -67,6 +68,7 @@ export function useAvatarClasses (props: UseAvatarClassesProps): {
avatarClasses: Ref<string>
avatarDotClasses: Ref<string>
avatarPlaceholderClasses: Ref<string>
avatarPlaceholderIconClasses: Ref<string>
avatarPlaceholderWrapperClasses: Ref<string>
avatarPlaceholderInitialsClasses: Ref<string>
} {
Expand All @@ -89,9 +91,17 @@ export function useAvatarClasses (props: UseAvatarClassesProps): {
const avatarPlaceholderClasses = computed<string>(() =>
useMergeClasses([
avatarPlaceholderDefaultClasses,
]),
)

const avatarPlaceholderIconClasses = computed<string>(() =>
useMergeClasses([
avatarPlaceholderDefaultClasses,
avatarPlaceholderDefaultIconClasses,
avatarPlaceholderSizes[props.size.value],
]),
)

const avatarPlaceholderWrapperClasses = computed<string>(() =>
useMergeClasses([
avatarPlaceholderWrapperDefaultClasses,
Expand All @@ -111,6 +121,7 @@ export function useAvatarClasses (props: UseAvatarClassesProps): {
avatarClasses,
avatarDotClasses,
avatarPlaceholderClasses,
avatarPlaceholderIconClasses,
avatarPlaceholderInitialsClasses,
avatarPlaceholderWrapperClasses,
}
Expand Down
Loading