Skip to content

feat: Label added for FileInput dropzone #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 11, 2025
+23 −17
Merged

feat: Label added for FileInput dropzone #304

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0ee8e66
feat: Label added for FileInput dropzone
ogzcode Jul 24, 2024
78ac82d
chore: Refactor FwbFileInput component lint
ogzcode Aug 2, 2024
08ca958
chore: Refactor FwbFileInput component lint
ogzcode Aug 2, 2024
971a2fa
fix: typo in fileInput documentation
Sqrcz Mar 10, 2025
ef7c501
fix: formatting of FileInput component
Sqrcz Mar 10, 2025
a72e3cc
Merge branch 'main' into fileinput-dropzone-label
Sqrcz Mar 11, 2025
3c8fd8b
Merge pull request #1 from themesberg/fileinput-dropzone-label
ogzcode Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/FwbFileInput/FwbFileInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@
</div>
<div
v-else
class="flex items-center justify-center"
class="flex flex-col items-start justify-center"
@change="handleChange"
@dragover="dragOverHandler"
@drop="dropFileHandler"
>
<span v-if="label !== ''" :class="labelClasses">{{ label }}</span>
Copy link
Collaborator

@Sqrcz Sqrcz Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix code style according to linter (npm run lint)

/src/components/FwbFileInput/FwbFileInput.vue
  23:1   warning  Expected indentation of 6 spaces but found 4 spaces   vue/html-indent
  23:31  warning  ':class' should be on a new line                      vue/max-attributes-per-line

Copy link
Contributor Author

@ogzcode ogzcode Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did npm run format. Lint was giving too many errors.

<label :class="dropzoneLabelClasses">
<div :class="dropzoneWrapClasses">
<svg
Expand Down