-
Notifications
You must be signed in to change notification settings - Fork 106
Address asciidoctor-dita-vale issues for rex #4379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aneta-petrova
wants to merge
9
commits into
theforeman:master
Choose a base branch
from
aneta-petrova:dita-hosts-rex
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+228
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If users have trouble navigating through an assembly, the solution is not to start throwing links at them; the solution is to fix up the assembly's structure
33e2c22
to
98ea4cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
To ensure a clean https://github.com/jhradilek/asciidoctor-dita-vale/ check for the procedure.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
The new lines are mostly not really new, just a result of splitting existing files into two. One exception is proc_customizing-job-templates.adoc (ex proc_setting-up-job-templates.adoc), which needed a lot of rewriting to address the issues.
Contributor checklists
Please cherry-pick my commits into: