feat: add network display user #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolves #43 |
pselle
reviewed
May 30, 2025
pselle
requested changes
May 30, 2025
There was a problem hiding this comment.
Looks good! My first comment was pattern matching what I saw in the image with a tooltip for the hover situation, but I think we can start here, so I scratched out that comment.
Only feedback for a change here is on using the stellarNetwork directly, otherwise looking good!
|
Should we avoid rendering the component if network is mainnet? That's the presumable long-term default userbase for the apps people will build. |
|
@chadoh I suggest we leave it for now since it's a request from Jane |
pselle
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a network pill component to display app's network to user
If the user's wallet is not connected the circle indicator is grey, if they are connected and on the same network as the app the indicator is green, if on a different network its red and a tooltip says that they are not on the same network as the app.