feat: final version of guess the number #116
Merged
+717
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: - Errors - XLM contract (had to make a work around since you can't unit test easily) - Method to add funds - More tests It was very hard to test the auth mocking for the guessing so just skipped it for now. A future improvement is to use an allowance and have the contract refill funds after a correct guess.
- Make both constants consistent as references - Rename `reset_guess` to `reset_number` - Add private readonly `number` getter
zachfedor
approved these changes
Oct 25, 2025
zachfedor
force-pushed
the
feat/final_guess_the_number
branch
from
1b9e682 to
81ab1d0
Compare
We already do this in the test? You and I figured it out together, @willemneal. Did this need to change for some reason? #[test]
fn only_admin_can_reset() {
let env = &Env::default();
let (admin, _, client) = init_test(env);
let user = Address::generate(env);
set_caller(&client, "reset", &user, ());
assert!(client.try_reset().is_err());
set_caller(&client, "reset", &admin, ());
assert!(client.try_reset().is_ok());
} |
|
@chadoh It's when adding the transfer that is hard. The cross contract call auth is tricky and I couldn't get it to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
It was very hard to test the auth mocking for the guessing so just skipped it for now.
A future improvement is to use an allowance and have the contract refill funds after a correct guess.