Attempt to allow Draupnir to use room V12. #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnuxie
force-pushed
the
gnuxie/room-v12-compat
branch
from
8457d50 to
ca1fa2c
Compare
nexy7574
approved these changes
Jul 16, 2025
Gnuxie
commented
Jul 16, 2025
Comment on lines
79
to
78
| const storeResult = await this.hashStore.storeRoomIdentification({ | ||
| creator: details.creator, | ||
| roomID: details.room_id, | ||
| server: roomIDServerName(details.room_id), | ||
| }); | ||
| if (isError(storeResult)) { | ||
| log.error( | ||
| "Error storing room details for a room", | ||
| roomID, | ||
| details, | ||
| storeResult | ||
| ); | ||
| } | ||
| // TODO: normally we would store details about the room, such as the creator, | ||
| // and the server, but currently this is unviable. | ||
| // https://matrix.org/blog/2025/07/security-predisclosure/ |
There was a problem hiding this comment.
Ok this grand idea doesn't work, we actually do depend on being able to extract the creator in tests.. even though in reality this code is probably populating the database with bad data....
There was a problem hiding this comment.
You could always provide a bogus server name if it's not critical
There was a problem hiding this comment.
Ok no there is a check for that above, my bad.
There was a problem hiding this comment.
Ok so all of these changes were unecessary lemao
- Updated to matrix-basic-types 1.4.0 which changes the regex validating room ids. - Changed the package override so that all dependencies use matrix-basic-types 1.4.0, including the matrix-protection-suite. - Removed code that tries to store details about discovered rooms in the room takdedown protection. These were unreliable for so many reasons and also are now broken given the room origin cannot be extracted from the room id. Details for why this is can be found in the reviews of matrix-org/matrix-spec-proposals#4291.
Gnuxie
force-pushed
the
gnuxie/room-v12-compat
branch
from
ca1fa2c to
b3ebec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to matrix-basic-types 1.4.0 which changes the regex validating room ids.
Changed the package override so that all dependencies use matrix-basic-types 1.4.0, including the matrix-protection-suite.
Removed code that tries to store details about discovered rooms in the room takdedown protection. These were unreliable for so many reasons and also are now broken given the room origin cannot be extracted from the room id. Details for why this is can be found in the reviews of MSC4291: Room IDs as hashes of the create event matrix-org/matrix-spec-proposals#4291.