Improve error #18
Merged
Improve error #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…analysis - Implement new rule to detect English syntax patterns translated to Japanese - Use kuromojin for accurate part-of-speech analysis to distinguish nouns from predicates - Allow natural Japanese expressions like '使い方:' (noun + colon) - Detect unnatural patterns like '実行します:' (predicate + colon) - Support AST-based detection for Paragraph + block element combinations - Remove duplicate colon detection from ai-tech-writing-guideline rule - Add comprehensive test coverage for various patterns Fixes #16
- Add support for both half-width (:) and full-width (：) colons - Include conjunction detection (例えば: should be flagged) - Port original test cases from ai-tech-writing-guideline - Ensure proper colon character display in error messages - All tests now passing with comprehensive pattern coverage
- Remove redundant colon index calculation - Determine colon type once and reuse - Remove unused colonIndex variable - Keep clean and efficient implementation
azu
added
the
Type: Refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16 follow up