Skip to content

Commit 1d44b9d

Browse files
committed
include binned scales
1 parent 89316f6 commit 1d44b9d

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

R/scale-.R

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1316,9 +1316,16 @@ ScaleBinned <- ggproto("ScaleBinned", Scale,
13161316
}
13171317
}
13181318
} else if (is.function(self$breaks)) {
1319-
if ("n.breaks" %in% names(formals(environment(self$breaks)$f))) {
1319+
fmls <- names(formals(environment(self$breaks)$f))
1320+
if (any(c("n", "n.breaks") %in% fmls)) {
13201321
n.breaks <- self$n.breaks %||% 5 # same default as trans objects
1321-
breaks <- self$breaks(limits, n.breaks = n.breaks)
1322+
# TODO: we should only allow `n` argument and not `n.breaks` to be
1323+
# consistent with other scales. We should start deprecation at some point.
1324+
if ("n.breaks" %in% fmls) {
1325+
breaks <- self$breaks(limits, n.breaks = n.breaks)
1326+
} else {
1327+
breaks <- self$breaks(limits, n = n.breaks)
1328+
}
13221329
} else {
13231330
if (!is.null(self$n.breaks)) {
13241331
cli::cli_warn(

0 commit comments

Comments
 (0)