-
Couldn't load subscription status.
- Fork 411
feat: add toBePressed matcher (#203) #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add toBePressed matcher (#203) #658
Conversation
|
Hi, may I ask for reviews? |
|
Hi @gnapse, can I kindly ask for a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this contribution. It is good stuff. Though there are a couple of things that need to be improved.
(the comments marked as "nit-pick" are not fundamental to be changed, but other ones are)
5a89af4 to
2662e5d
Compare
|
@all-contributors please add @kretajak for code, test |
|
I've put up a pull request to add @kretajak! 🎉 |
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I have created a follow-up with |
What:
New
toBePressedmatcher is addedWhy:
Closes #203
Checklist:
In my opinion this PR could be followed by another one which would add support for checking
aria-pressed="mixed". MaybetoBePartiallyPressed? It would follow the same approach as splittertoBeCheckedandtoBePartiallyCheckedinto two separate matchers.