-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Use generic init script filename when copying it into a Cassandra container #9606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @maximevw, sorry for the delay. I can confirm that the fixed code works for me. Is there any chance to review and merge this? Thanks |
Hello @lorenzopatane, Glad to read this. Unfortunately, I can't merge this pull request by myself. |
Hello @eddumelendez @rnacher @bsideup. Just a ping to notify all of you. This contribution seems to work and it is here by more than one month. It fixes an issue with the new Cassandra Container class. Once the deprecated one gets deleted, we won't be able to use Cassandra test containers anymore. Is it possible to review this simple logic change anytime soon? |
@lorenzopatane @maximevw @rnacher @eddumelendez @bsideup |
I do not know unfortunately, apart from requesting a review to the mainteiners as you already done. |
@lorenzopatane Maybe you could post a message in Slack: here or there. |
Thanks, will try tomorrow morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @maximevw for missing this, thanks @lorenzopatane for the ping in Slack.
LGTM, but I will leave @eddumelendez to merge.
Thanks for your contribution, @maximevw ! and sorry for the delay. |
Instead of trying to retrieve the name of the init script file from its URI (not working if the file is inside a JAR), simplify the logic to use a generic name.
fixes #9574