-
Notifications
You must be signed in to change notification settings - Fork 27
Check for proj codes as str or int in CoordinateMousePositionPanel #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@KaiVolland - looking at the history this may be intentional? 5116f3c |
Contributor
Author
|
Alternately, the mapCode could be converted to an int: |
KaiVolland
reviewed
Jan 20, 2025
KaiVolland
approved these changes
Jan 21, 2025
Member
|
@dnlkoch can you please have an additional look and then merge it if it is fine for you. |
dnlkoch
reviewed
Jan 21, 2025
dnlkoch
approved these changes
Jan 22, 2025
Member
|
Thanks @geographika! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment states
// Loose equality check since code could be a string or an inthowever an exact check is used.This then causes
filteredto be an empty array when checking3857 ==== "3857"between a projection code in the store and the projection code from the map.Results in the JS error:
In addition the
filtered ? filtered[0].name : ''will returntruefor an empty array (which is always created using Ext.Array.filter) - updated to account for this.