208 add kv store #889
Open
208 add kv store #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbitz
force-pushed
the
208-add-kv-store
branch
4 times, most recently
from
37adf6b to
ec176ee
Compare
orbitz
force-pushed
the
208-add-kv-store
branch
6 times, most recently
from
e0fe717 to
895728a
Compare
orbitz
force-pushed
the
208-add-kv-store
branch
10 times, most recently
from
6df87b8 to
14906c3
Compare
orbitz
force-pushed
the
208-add-kv-store
branch
from
308d10f to
af7e5ba
Compare
orbitz
force-pushed
the
208-add-kv-store
branch
3 times, most recently
from
bca9ffa to
cabe54d
Compare
orbitz
force-pushed
the
208-add-kv-store
branch
from
cabe54d to
8fa1b0f
Compare
This comment has been minimized.
This comment has been minimized.
orbitz
force-pushed
the
208-add-kv-store
branch
from
8fa1b0f to
92ab6e9
Compare
This comment has been minimized.
This comment has been minimized.
Plans 👍Outputs can be viewed in the Terrateam Console here. Terrateam Plan Output 👍Expand for plan output detailsDir: code | No changesDir: code Step: run Step: plan To apply all these changes, comment:
|
schonfinkel
reviewed
Oct 22, 2025
schonfinkel
requested changes
Oct 23, 2025
schonfinkel
reviewed
Oct 23, 2025
Comment on lines
+11
to
+21
| (* TODO: Make this use the proper Abb time *) | ||
| let time = Unix.gettimeofday () in | ||
| let time_str = ISO8601.Permissive.string_of_datetime time in | ||
| Format.kfprintf | ||
| k | ||
| ppf | ||
| ("[%s] %a [%s] @[" ^^ fmt ^^ "@]@.") | ||
| time_str | ||
| Logs.pp_header | ||
| (level, h) | ||
| (Logs.Src.name src) |
There was a problem hiding this comment.
Will this TODO apply to a later PR or this was forgotten here?
There was a problem hiding this comment.
That TODO has been there for 5 years 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist
ISSUE_NUMBER ACTION_TYPE Short description(e.g.,123 ADD Feature description)Additional context (optional)