Skip to content

Replace service endpoints with allowed networks #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Replace service endpoints with allowed networks #69

merged 2 commits into from
Apr 11, 2024

Conversation

shemau
Copy link
Contributor

@shemau shemau commented Mar 28, 2024

Description

#49 service endpoints are not used with secrets manager instances, allowed_networks is used instead.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

The input service_endpoints was removed and replaced with allowed_networks which can be public-and-private or private-only.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau
Copy link
Contributor Author

shemau commented Mar 28, 2024

/run pipeline

@shemau shemau requested a review from alex-reiff as a code owner April 11, 2024 11:07
@shemau
Copy link
Contributor Author

shemau commented Apr 11, 2024

/run pipeline

@ocofaigh ocofaigh merged commit 1f9ff19 into main Apr 11, 2024
2 checks passed
@ocofaigh ocofaigh deleted the endpoints branch April 11, 2024 11:59
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants