Create DA #226
Open
Create DA #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
alex-reiff
reviewed
May 20, 2025
shemau
requested changes
May 21, 2025
solutions/fully-configurable/catalogValidationValues.json.template
Outdated
Show resolved
Hide resolved
|
/run pipeline |
|
/run pipeline |
|
@Ak-sky you must be in the team github-collaborators in order to trigger the pipeline. |
|
/run pipeline |
|
/run pipeline |
ocofaigh
requested changes
Jun 4, 2025
There was a problem hiding this comment.
- can you review each of the variable descrption and add a "Learn more" link to the official docs which explain more information on each of the features we are expsoing to configure
- the diagram doesn't show any communcation with CIS
- can you follow up with docs team for content review please?
|
/run pipeline |
|
/run pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.ibm.com/GoldenEye/issues/issues/13201
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Add a Deployable Architecture for Secrets Manager Public Certificates Engine.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers