Skip to content

feat: update names of stacks #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: update names of stacks #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 45 additions & 45 deletions stack_definition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,44 @@
"value": "ref:../../inputs/prefix"
}
],
"name": "1 - core-security-services-kms",
"name": "1 - Key Protect",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 - Key management

"version_locator": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3.8493fc70-8755-47c2-a696-ddabe2031673-global"
},
{
"inputs": [
{
"name": "kms_endpoint_url",
"value": "ref:../../members/1 - Key Protect/outputs/kp_private_endpoint"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key management

},
{
"name": "existing_kms_instance_crn",
"value": "ref:../../members/1 - Key Protect/outputs/key_protect_crn"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key management

},
{
"name": "kms_endpoint_type",
"value": "private"
},
{
"name": "resource_group_name",
"value": "ref:../../members/1 - Key Protect/outputs/resource_group_name"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key management

},
{
"name": "use_existing_resource_group",
"value": true
},
{
"name": "region",
"value": "ref:../../inputs/region"
}
],
"name": "2 - IBM Cloud Logs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are you getting this from? Cloud logs is not even publicly available yet. As per Allen's comment in the issue, got with 2 - Logging, monitoring, activity tracking

"version_locator": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3.32981b83-1aba-493e-be15-9c951578b1fb-global"
},
{
"inputs": [
{
"name": "resource_group_name",
"value": "ref:../../members/1 - core-security-services-kms/outputs/resource_group_name"
"value": "ref:../../members/1 - Key Protect/outputs/resource_group_name"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key management

},
{
"name": "use_existing_resource_group",
Expand All @@ -107,7 +137,7 @@
},
{
"name": "existing_kms_instance_crn",
"value": "ref:../../members/1 - core-security-services-kms/outputs/key_protect_crn"
"value": "ref:../../members/1 - Key Protect/outputs/key_protect_crn"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key management

},
{
"name": "cos_instance_name",
Expand All @@ -130,44 +160,14 @@
"value": "ref:../../inputs/enable_platform_logs_metrics"
}
],
"name": "3 - core-security-observability",
"name": "3 - Event Notifications",
"version_locator": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3.dbb2626f-f6d7-498c-9a89-3a0b69997b8a-global"
},
{
"inputs": [
{
"name": "kms_endpoint_url",
"value": "ref:../../members/1 - core-security-services-kms/outputs/kp_private_endpoint"
},
{
"name": "existing_kms_instance_crn",
"value": "ref:../../members/1 - core-security-services-kms/outputs/key_protect_crn"
},
{
"name": "kms_endpoint_type",
"value": "private"
},
{
"name": "resource_group_name",
"value": "ref:../../members/1 - core-security-services-kms/outputs/resource_group_name"
},
{
"name": "use_existing_resource_group",
"value": true
},
{
"name": "region",
"value": "ref:../../inputs/region"
}
],
"name": "2 - core-security-services-en",
"version_locator": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3.32981b83-1aba-493e-be15-9c951578b1fb-global"
},
{
"inputs": [
{
"name": "resource_group_name",
"value": "ref:../../members/1 - core-security-services-kms/outputs/resource_group_name"
"value": "ref:../../members/1 - Key Protect/outputs/resource_group_name"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key management

},
{
"name": "use_existing_resource_group",
Expand All @@ -183,19 +183,19 @@
},
{
"name": "existing_kms_instance_crn",
"value": "ref:../../members/1 - core-security-services-kms/outputs/key_protect_crn"
"value": "ref:../../members/1 - Key Protect/outputs/key_protect_crn"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key management

},
{
"name": "existing_monitoring_crn",
"value": "ref:../../members/3 - core-security-observability/outputs/cloud_monitoring_crn"
"value": "ref:../../members/3 - Event Notifications/outputs/cloud_monitoring_crn"
},
{
"name": "existing_cos_instance_crn",
"value": "ref:../../members/3 - core-security-observability/outputs/cos_instance_crn"
"value": "ref:../../members/3 - Event Notifications/outputs/cos_instance_crn"
},
{
"name": "existing_en_crn",
"value": "ref:../../members/2 - core-security-services-en/outputs/crn"
"value": "ref:../../members/2 - IBM Cloud Logs/outputs/crn"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 - Logging, monitoring, activity tracking

},
{
"name": "kms_endpoint_type",
Expand All @@ -207,21 +207,21 @@
},
{
"name": "existing_en_crn",
"value": "ref:../../members/2 - core-security-services-en/outputs/crn"
"value": "ref:../../members/2 - IBM Cloud Logs/outputs/crn"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 - Logging, monitoring, activity tracking

},
{
"name": "scc_service_plan",
"value": "ref:../../inputs/scc_service_plan"
}
],
"name": "4a - core-security-services-scc",
"name": "4a - Secrets Manager",
"version_locator": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3.09aeab5e-2f02-4a86-a281-844fa19d969d-global"
},
{
"inputs": [
{
"name": "resource_group_name",
"value": "ref:../../members/1 - core-security-services-kms/outputs/resource_group_name"
"value": "ref:../../members/1 - Key Protect/outputs/resource_group_name"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key management

},
{
"name": "use_existing_resource_group",
Expand All @@ -237,11 +237,11 @@
},
{
"name": "existing_kms_instance_crn",
"value": "ref:../../members/1 - core-security-services-kms/outputs/key_protect_crn"
"value": "ref:../../members/1 - Key Protect/outputs/key_protect_crn"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key management

},
{
"name": "existing_event_notification_instance_crn",
"value": "ref:../../members/2 - core-security-services-en/outputs/crn"
"value": "ref:../../members/2 - IBM Cloud Logs/outputs/crn"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 - Logging, monitoring, activity tracking

},
{
"name": "existing_secrets_manager_crn",
Expand All @@ -252,7 +252,7 @@
"value": "ref:../../inputs/sm_service_plan"
}
],
"name": "4b - core-security-services-sm",
"name": "4b - Security and Compliance Center",
"version_locator": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3.ba032ffb-286c-4a00-ad79-ae9e09cea687-global"
}
]
Expand Down