feat: Complex variable types for module zones #111
Conversation
kevcube
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Not stale |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This is really nice! Any chance of getting your input here @antonbabenko ? |
Yes, I plan to get back to this and many other PRs in terraform-aws-modules after AWS reinvent. |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
How was re:invent @antonbabenko ? 😅 |
There was a problem hiding this comment.
These changes certainly look like an improvement, but it is essential to keep backward compatibility in mind and don't introduce breaking changes.
Please make sure that the code in examples/complete works as expected (now I see the error: each.value.vpc is null Cannot use a null value in for_each.).
@BeyondEvil Thanks for asking, it went well - https://www.youtube.com/watch?v=fX7c2GGqTWs 😅 |
antonbabenko
changed the title
Oh nice! I'll have a look. 👍 |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
ping @kevcube |
|
not stale |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
not stale I might be able to fix the issue in a couple of weeks if @kevcube doesn't respond. |
| name = lookup(each.value, "domain_name", each.key) | ||
| comment = lookup(each.value, "comment", null) | ||
| force_destroy = lookup(each.value, "force_destroy", false) | ||
| name = coalesce(each.value.domain_name, each.key) |
There was a problem hiding this comment.
| name = coalesce(each.value.domain_name, each.key) | |
| name = try(each.value.domain_name, each.key) |
| type = map(object({ | ||
| domain_name = optional(string) | ||
| comment = optional(string) | ||
| force_destroy = optional(bool) |
There was a problem hiding this comment.
to maintain current behavior:
| force_destroy = optional(bool) | |
| force_destroy = optional(bool, false) |
|
|
||
| dynamic "vpc" { | ||
| for_each = try(tolist(lookup(each.value, "vpc", [])), [lookup(each.value, "vpc", {})]) | ||
| for_each = each.value.vpc |
There was a problem hiding this comment.
not quite, I think we need more guards/checks
| for_each = each.value.vpc | |
| for_each = each.value.vpc != null ? each.value.vpc : [] |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR was automatically closed because of stale in 10 days |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
use descriptive variable types.
versions.tfalready specifies higher than 1.3.0 so no change needed there.