Skip to content

feat!: Add primary name server to outputs in modules/zones. Bump AWS provider version to 4 #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2024
Merged

feat!: Add primary name server to outputs in modules/zones. Bump AWS provider version to 4 #108

merged 2 commits into from
Aug 17, 2024

Conversation

sapphireqt
Copy link
Contributor

@sapphireqt sapphireqt commented Jun 17, 2024 •
edited
Loading

Description

One more output has been added in zones module in this PR: primary_name_server.

Motivation and Context

This new output could be useful if SOA record modification is required in dependent modules.

Breaking Changes

No breaking changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 11, 2024
antonbabenko
antonbabenko requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update versions.tf to require AWS provider version 4.36.0 or newer since this is when primary_name_server attribute was introduced.

It will have to be a major release.

@antonbabenko antonbabenko changed the title feat(zones): Add primary name server to outputs feat!: Add primary name server to outputs Aug 16, 2024
@antonbabenko antonbabenko changed the title feat!: Add primary name server to outputs feat!: Add primary name server to outputs in modules/zones Aug 16, 2024
@sapphireqt
Copy link
Contributor Author

Thank you for for your review. I've updated the version of aws provider at zones module.

@antonbabenko antonbabenko changed the title feat!: Add primary name server to outputs in modules/zones feat!: Add primary name server to outputs in modules/zones. Bump AWS provider version to 4 Aug 17, 2024
@antonbabenko antonbabenko merged commit 0fa1069 into terraform-aws-modules:master Aug 17, 2024
11 checks passed
antonbabenko pushed a commit that referenced this pull request Aug 17, 2024
@semantic-release-bot
chore(release): version 4.0.0 [skip ci]
bbbe69c 
## [4.0.0](v3.1.0...v4.0.0) (2024-08-17)

### ⚠ BREAKING CHANGES

* Add primary name server to outputs in modules/zones. Bump AWS provider version to 4 (#108)

### Features

* Add primary name server to outputs in modules/zones. Bump AWS provider version to 4 ([#108](#108)) ([0fa1069](0fa1069))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.0 🎉

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

@marko-fabry marko-fabry marko-fabry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sapphireqt @antonbabenko @marko-fabry