feat!: Add support for geoproximity routing policy. Upgraded TF version to 1.3.2 #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhutkovskyysos
changed the title
jcobbsos
approved these changes
May 17, 2024
jcobbsos
approved these changes
May 20, 2024
|
Hi @antonbabenko, Is there any chance we could get this approved and merged? Thx! |
antonbabenko
changed the title
antonbabenko
reviewed
Jun 8, 2024
examples/complete/main.tf
Outdated
| set_identifier = "nyc" | ||
| geoproximity_routing_policy = { | ||
| coordinates = { | ||
| latitude = "40.7128" |
There was a problem hiding this comment.
Value 40.7128 produced an error:
│ Error: creating Route53 Record: operation error Route 53: ChangeResourceRecordSets, https response error StatusCode: 400, RequestID: 54c0a63c-e5b4-4fda-864b-a10e3cc928a7, InvalidInput: Invalid XML ; javax.xml.stream.XMLStreamException: org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 237; cvc-pattern-valid: Value '40.7128' is not facet-valid with respect to pattern '[-+]?(90|[0-8]{0,1}[0-9](\.[0-9]{0,2})?)' for type 'Latitude'.
There was a problem hiding this comment.
hmm odd, it worked for me locally when I tested. Thank you for catching and fixing it!
antonbabenko
changed the title
|
This PR is included in version 3.0.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change extends the route53 records module by adding support for geoproximity routing policy.
Motivation and Context
AWS recently added support for geopriximity routing and this change will allow creation of records using that new policy. The module currently does not support it.
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request