Skip to content

fix: Skip zone_awareness_config if zone_awareness is not enabled #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2024
Merged

fix: Skip zone_awareness_config if zone_awareness is not enabled #32

merged 2 commits into from
Nov 29, 2024

Conversation

mvalo
Copy link
Contributor

@mvalo mvalo commented Nov 14, 2024

Description

zone_awareness_config should be considered only if zone_awareness is enabled.

Motivation and Context

When zone_awareness_enabled is false and zone_awareness_config is set (whatever the value, even null or {}), the module keeps trying to modify aws opensearch cluster and apply this zone_awareness_config. Obvisouly AWS doesn't consider it since awareness_config is only relevant when awareness is enabled. So this provokes a continuous terraform drift.
Note that we can't just remove the zone_awareness_config from our TF code since we actually uses it for some environements.

How Has This Been Tested?

  • I modified the module locally and there is no more a terraform drift. Module won't apply any zone_awareness_config if zone_awareness_enabled is false

@mvalo mvalo changed the title fix: consider zone_awareness_config only if zone_awareness is enabled fix: zone_awareness_config should be considered only if zone_awareness is enabled Nov 14, 2024
@mvalo mvalo changed the title fix: zone_awareness_config should be considered only if zone_awareness is enabled fix: Zone_awareness_config should be considered only if zone_awareness is enabled Nov 14, 2024
@bryantbiggs bryantbiggs changed the title fix: Zone_awareness_config should be considered only if zone_awareness is enabled fix: Skip zone_awareness_config if zone_awareness is not enabled Nov 29, 2024
@bryantbiggs bryantbiggs merged commit 1ff02d2 into terraform-aws-modules:master Nov 29, 2024
9 checks passed
antonbabenko pushed a commit that referenced this pull request Nov 29, 2024
## [1.4.1](v1.4.0...v1.4.1) (2024-11-29)

### Bug Fixes

* Skip `zone_awareness_config` if `zone_awareness` is not enabled ([#32](#32)) ([1ff02d2](1ff02d2))
* Update CI workflow versions to latest ([#29](#29)) ([dde73c8](dde73c8))
@antonbabenko
Copy link
Member

This PR is included in version 1.4.1 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants