Skip to content

feat: Add nullable = false to variables with defaults in submodules #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

abohne
Copy link

@abohne abohne commented Nov 8, 2024

Description

This PR sets nullable = false on variables in the policy and rule-group submodules. This causes terraform to use the default variables instead of null when using the submodules outside of this module.

Motivation and Context

If you are trying to use the policy and/or rule-group submodules outside of the main module, you cannot utilize the defaults in the submodules' variables by using null as the value in a variable.

Breaking Changes

This should not break anything

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
    I applied the complete example and also validated that the submodules behave as expected when null values are passed into them.
  • I have executed pre-commit run -a on my pull request

@abohne abohne changed the title Add nullable = false to variables with defaults in submodules feat: Add nullable = false to variables with defaults in submodules Nov 8, 2024
@abohne
Copy link
Author

abohne commented Nov 25, 2024

@bryantbiggs Not sure if you're the correct person to tag, but would be nice to get this reviewed/merged

@bryantbiggs
Copy link
Member

its not going to be something added fairly quickly - theres quite a bit more work involved before this would be added

@abohne
Copy link
Author

abohne commented Jan 13, 2025

What additional work is required?

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 30, 2025
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Apr 10, 2025
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants