fix: Remove restriction on engine to allow Valkey cluster creation #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provider bug was fixed in 5.84, but version is already bumped to 5.93, so no update needed. Fix: terraform-aws-modules#43
Nklya
changed the title
Nklya
changed the title
bryantbiggs
changed the title
bryantbiggs
approved these changes
Jul 21, 2025
bryantbiggs
merged commit b3fe278
into
terraform-aws-modules:master
19 of 21 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Jul 21, 2025
## [1.6.1](v1.6.0...v1.6.1) (2025-07-21) ### Bug Fixes * Remove restriction on engine to allow Valkey cluster creation ([#44](#44)) ([b3fe278](b3fe278))
|
This PR is included in version 1.6.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove local.create_cluster logic due to fixed provider bug
Motivation and Context
Bug in provider fixed in 5.84, should be working now without local override.
Provider version is already bumped to 5.93, so no update in
required_providersneeded.Fixes #43
Breaking Changes
None
How Has This Been Tested?
I'm returning here code that was working fine before #26. I'll try to test different scenarios tomorrow to ensure that Valkey works as expected.
pre-commit run -aon my pull request