Skip to content

Conversation

@armin-x86
Copy link
Contributor

fix(user-group): use lowercase default for engine to prevent Terraform warning

Description

This PR updates the default value of the engine variable in the modules/user-group module from "REDIS" to "redis" to align with Terraform's expected values and eliminate deprecation warnings.

Background

Terraform has deprecated case-insensitive matching for the engine argument in the aws_elasticache_user_group resource. Using "REDIS" (uppercase) results in the following warning:

╷
│ Warning: Case Insensitive Matching Deprecated
│   on .terraform/modules/elasticache_user_group/modules/user-group/main.tf line 12, in resource "aws_elasticache_user_group" "this":
│   12:   engine        = var.engine
│
│ Expected an exact match to "redis", got "REDIS". Case insensitive matching is deprecated for this argument. Update the value to an exact match to suppress this warning and avoid breaking changes in a
│ future major version.
╵

Switching the default to "redis" ensures forward compatibility and removes the warning.

Changes

  • Changed default = "REDIS" to default = "redis" in modules/user-group/variables.tf

References

Checklist

  • Variable updated without breaking change
  • Consistent with AWS provider requirements
  • No documentation update necessary (default value only)
  • Examples verified (N/A - not dependent on engine default)

Let me know if any additional context or changes are required.

… warning

Signed-off-by: armin-x86 <arminteymuri@gmail.com>
@armin-x86 armin-x86 changed the title fix(user-group): use lowercase default for engine to prevent Terraform warning FIX user-group: use lowercase default for engine to prevent Terraform warning Jul 16, 2025
@armin-x86 armin-x86 changed the title FIX user-group: use lowercase default for engine to prevent Terraform warning fix: use lowercase default for engine to prevent Terraform warning Jul 16, 2025
@armin-x86 armin-x86 changed the title fix: use lowercase default for engine to prevent Terraform warning Fix: use lowercase default for engine to prevent Terraform warning Jul 16, 2025
@armin-x86 armin-x86 changed the title Fix: use lowercase default for engine to prevent Terraform warning Fix(user-group): use lowercase default for engine to prevent Terraform warning Jul 16, 2025
@bryantbiggs bryantbiggs changed the title Fix(user-group): use lowercase default for engine to prevent Terraform warning fix: Use lowercase form of default engine "redis" Jul 21, 2025
@bryantbiggs bryantbiggs merged commit 0695d6a into terraform-aws-modules:master Jul 21, 2025
15 checks passed
antonbabenko pushed a commit that referenced this pull request Jul 21, 2025
## [1.6.2](v1.6.1...v1.6.2) (2025-07-21)

### Bug Fixes

* Use lowercase form of default engine `"redis"` ([#41](#41)) ([0695d6a](0695d6a))
@antonbabenko
Copy link
Member

This PR is included in version 1.6.2 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants