feat: Upgrade AWS provider to v6 and remove deprecated arguments: elastic_gpu_specifications and elastic_inference_accelerator

[dennisameling]

Description

We forked this repo to check what's needed for it to work with the AWS v6 provider. In our testing, we only ran into problems with the elastic_gpu_specifications and elastic_inference_accelerator arguments:

╷
│ Error: Unsupported block type
│ 
│   on .terraform/modules/eks.k8s_cluster/modules/eks-managed-node-group/main.tf line 140, in resource "aws_launch_template" "this":
│  140:   dynamic "elastic_gpu_specifications" {
│ 
│ Blocks of type "elastic_gpu_specifications" are not expected here.
╵
╷
│ Error: Unsupported block type
│ 
│   on .terraform/modules/eks.k8s_cluster/modules/eks-managed-node-group/main.tf line 148, in resource "aws_launch_template" "this":
│  148:   dynamic "elastic_inference_accelerator" {
│ 
│ Blocks of type "elastic_inference_accelerator" are not expected here.
╵
╷
│ Error: Unsupported block type
│ 
│   on .terraform/modules/eks.k8s_cluster/modules/self-managed-node-group/main.tf line 203, in resource "aws_launch_template" "this":
│  203:   dynamic "elastic_gpu_specifications" {
│ 
│ Blocks of type "elastic_gpu_specifications" are not expected here.
╵
╷
│ Error: Unsupported block type
│ 
│   on .terraform/modules/eks.k8s_cluster/modules/self-managed-node-group/main.tf line 211, in resource "aws_launch_template" "this":
│  211:   dynamic "elastic_inference_accelerator" {
│ 
│ Blocks of type "elastic_inference_accelerator" are not expected here.

Once we removed these, our setup worked right away with v6 of the AWS provider.

Motivation and Context

Hopefully this helps in the path to AWS provider v6 support: #3386

Breaking Changes

This is a breaking change, because users of this module can no longer provide elastic_gpu_specifications and elastic_inference_accelerator variables to the module.

This addresses some breaking changes in v6 of the AWS provider:

• resource/aws_launch_template: elastic_gpu_specifications has been removed ([r/d]/aws_launch_template: remove elastic_gpu_specifications attribute hashicorp/terraform-provider-aws#42312)
• resource/aws_launch_template: Remove elastic_inference_accelerator attribute. Amazon Elastic Inference reached end of life on April, 2024. (ec2, ecs: EOL Amazon Elastic Inference hashicorp/terraform-provider-aws#42137)

How Has This Been Tested?

We are running these changes in our production environment with the AWS provider v6 and can confirm that everything's working as expected.

I'll file a separate PR to bump the hashicorp/aws version to >= 6.0.0 in the main module and the examples.

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[dennisameling]

Just went through all of the folders in examples/* and did a terraform plan on each of them in our environment. All looking good, no errors popped up! 🚀

[dennisameling]

Closing in favor of #3385. At least good to see that things are working as expected on v6 of the provider.