Skip to content

Fix: custom domain dns validation without manual intervention #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yasithab
Copy link

@yasithab yasithab commented Apr 9, 2025

Description

This pull request will automate custom domain DNS validation in app runner.

Motivation and Context

  • The existing code necessitates manual intervention to validate records, as outlined in the issue here.
  • This pull request will resolve the problem, enabling users to automatically validate custom domains in App Runner.

Breaking Changes

  • N/A

How Has This Been Tested?

  • Set up a resource using the example configurations provided.
  • Modified the custom domain to ensure it automatically recreates records.

@yasithab yasithab changed the title fix: custom domain dns validation without manual intervention Fix: custom domain dns validation without manual intervention Apr 10, 2025
@magic7s
Copy link

magic7s commented Apr 29, 2025

This would help a lot. Is there a maintainer that can review this?

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label May 30, 2025
@praneetloke
Copy link

+1 to merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants