Skip to content

feat: Support http respond headers for ALB listeners #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

feat: Support http respond headers for ALB listeners #398

merged 2 commits into from
Mar 13, 2025

Conversation

ekirmayer
Copy link
Contributor

@ekirmayer ekirmayer commented Jan 17, 2025 •
edited by bryantbiggs
Loading

Description

Add support for HTTP Respond headers.
Allow setting each value.
Create a lifecycle trigger as the provider will not update the value in place.

Motivation and Context

Resolves #397

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@ekirmayer ekirmayer changed the title Support http respond headers for ALB listeners feat: Support http respond headers for ALB listeners Jan 17, 2025
bryantbiggs
bryantbiggs reviewed Jan 17, 2025
View reviewed changes
bryantbiggs
bryantbiggs reviewed Jan 17, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Feb 17, 2025
@github-actions github-actions bot removed the stale label Feb 26, 2025
@ekirmayer ekirmayer force-pushed the feature/support_listener_response_headers branch from ed6e379 to 04dc9de Compare February 26, 2025 19:43
@crisboarna
Copy link

Hi @bryantbiggs ,

Could you please review this PR as @nathanbowang has already approved it, I find myself needing this feature for my application and it seems to be so close to landing ! :)

@jfagoagas
Copy link

Having this would be amazing and a great step forward in the module towards secure ALBs 🚀

@bryantbiggs bryantbiggs force-pushed the feature/support_listener_response_headers branch from 04cb292 to d85057e Compare March 13, 2025 12:47
@bryantbiggs bryantbiggs merged commit 9cf65cc into terraform-aws-modules:master Mar 13, 2025
10 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 13, 2025
@semantic-release-bot
chore(release): version 9.14.0 [skip ci]
cae590e 
## [9.14.0](v9.13.0...v9.14.0) (2025-03-13)

### Features

* Support http respond headers for  ALB listeners ([#398](#398)) ([9cf65cc](9cf65cc))
@antonbabenko
Copy link
Member

This PR is included in version 9.14.0 🎉

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@nathanbowang nathanbowang nathanbowang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add adding headers to ALB listeners
6 participants
@ekirmayer @crisboarna @jfagoagas @antonbabenko @bryantbiggs @nathanbowang