Adding streaming_conv reference code. #2521
Conversation
| @@ -120,9 +120,11 @@ TFLMRegistration Register_CONV_2D() { | |||
| return tflite::micro::RegisterOp(ConvInitXtensa, ConvPrepareXtensa, Eval); | |||
| } | |||
|
|
|||
| #if 0 | |||
There was a problem hiding this comment.
Can we go ahead and remove this function now?
| /* TODO(b/277112516): Dilation is currently not supported on HiFi 4 NN Library | ||
| */ | ||
| bool inputs_and_bias_ok = bias != nullptr; | ||
| #if defined(HIFI3) || defined(HIFI4) |
| (input->type == kTfLiteInt8 || | ||
| (input->type == kTfLiteInt16 && bias->type == kTfLiteInt64)); | ||
| #else | ||
| inputs_and_bias_ok = inputs_and_bias_ok && (input->type == kTfLiteInt8); |
There was a problem hiding this comment.
Or is this supposed to be for HIFI5?
|
|
||
| switch (input->type) { | ||
| case kTfLiteInt16: { | ||
| #if defined(HIFI3) || defined(HIFI4) |
| // http://b/262003750). As such, while we have a fallback to the reference | ||
| // implementation, production use-cases should only have int64 bias. | ||
| if (bias->type == kTfLiteInt32) { | ||
| return ConvReferenceEvalInt16(context, node); |
There was a problem hiding this comment.
Should this be StreamingConvReferenceEvalInt16?
| bias, output); | ||
| } | ||
| #else | ||
| return ConvReferenceEvalInt16(context, node); |
There was a problem hiding this comment.
Should this be StreamingConvReferenceEvalInt16?
@rascani, current changes are related to HiFi 4 only. we are planning to add HiFi 5 changes as well. |
|
@rascani, added HiFi 5 changes as well. |
|
@vnileshdaiict can you sign the CLA? |
|
Hi,
We have pushed the same changes with cad-audio account.
Please ignore the PR raised from this account.
Thanks and Regards,
Nileshkumar
…On Sat, Apr 20, 2024, 03:14 RJ Ascani ***@***.***> wrote:
@vnileshdaiict <https://github.com/vnileshdaiict> can you sign the CLA?
—
Reply to this email directly, view it on GitHub
<#2521 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFYXA2SQIWOSVCF35BQJ73LY6GF2XAVCNFSM6AAAAABFJHFK6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGMYTQNBVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
This is the PR from cad-audio, but the CLA is required to be signed by all accounts that have a commit on the PR. Since you have a commit on the PR, the change cannot be merged until you sign the CLA. |
|
@Mergifyio refresh |
✅ Pull request refreshed |
BUG=b/327502734