Skip to content

Refator benchmarks #5733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bolajahmad
Copy link

@bolajahmad bolajahmad commented Oct 17, 2021

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This PR is meant to resolve the issue #5633

  • It refactors the preconfigured_browser.json
  • updates the benchmarkAll function to reflect the new update
  • refactors the tests related
  • writes a benchmarkAll test and make sure result is returned

This change is Reviewable

@google-cla google-cla bot added the cla: yes label Oct 17, 2021
Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bolajahmad, thank you for the contribution. There are too many style changes unrelated to the issue, please clean them up. Otherwise, it's too hard to review.

Reviewable status: 0 of 1 approvals obtained (waiting on @bolajahmad)


e2e/benchmarks/browserstack-benchmark/app.js, line 23 at r1 (raw file):

Quoted 8 lines of code…
const http = require("http");
const socketio = require("socket.io");
const fs = require("fs");
const path = require("path");
const { execFile } = require("child_process");
const { ArgumentParser } = require("argparse");
const { version } = require("./package.json");
const { resolve } = require("path");

These style changes are unnecessary. Same for a lot of the changes below.

@bolajahmad
Copy link
Author

Hi @bolajahmad, thank you for the contribution. There are too many style changes unrelated to the issue, please clean them up. Otherwise, it's too hard to review.

Reviewable status: 0 of 1 approvals obtained (waiting on @bolajahmad)

e2e/benchmarks/browserstack-benchmark/app.js, line 23 at r1 (raw file):

Quoted 8 lines of code…

const http = require("http");
const socketio = require("socket.io");
const fs = require("fs");
const path = require("path");
const { execFile } = require("child_process");
const { ArgumentParser } = require("argparse");
const { version } = require("./package.json");
const { resolve } = require("path");

These style changes are unnecessary. Same for a lot of the changes below.

Thank you for reviewing my PR. Should I not require the modules I am requiring now, I think a lot of changes will break if I do not. Or are you referring to the space between inside the object? I am not sure I understand what I need to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants