[webgpu] Use different global index for flat and non-flat dispatch #5706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qjia7 @haoyunfeix @xhcao @gyagp PTAL |
qjia7
reviewed
Oct 9, 2021
| @@ -65,7 +65,7 @@ export class SliceProgram implements WebGPUProgram { | |||
|
|
|||
| const userCode = ` | |||
| ${getMainHeaderString()} { | |||
| ${getGlobalIndexString()} | |||
| ${getGlobalIndexString(true)} | |||
There was a problem hiding this comment.
SliceProgram uses the flat dispatch layout. Why pass true here?
There was a problem hiding this comment.
You are right, fixed.
qjia7
reviewed
Oct 9, 2021
axinging
force-pushed
the
globalindex_fix
branch
from
92fb01f to
dc08875
Compare
qjia7
reviewed
Oct 14, 2021
| let outputCoords : ${ | ||
| outputCoordsType} = getOutputCoords(globalId, globalIndex); | ||
| outputCoordsType} = getOutputCoords(globalId, i32(globalId.x)); |
There was a problem hiding this comment.
The second parameter seems like meaningless for non-flat dispatch. You already passed globalId. But you still have to pass globalId.x. I prefer that you refactor getXXX method to remove the dependency of globalIndex. Similar for other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is