webgpu: remove if-else block of getGlobalIndex #5594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a little performance loss for if-else block when calling shader getGlobalIndex function at high frequency, so remove if-else block.
|
@qjia7 @haoyunfeix @axinging @gyagp, please take a look, thank you. |
|
I had run some models on different platforms, Intel TGL and CFL, AMD RX6900XT, no evident performance loses for the if-else block, so I don't want to upstream this patch. Do you have any comments about it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a little performance loss for if-else block when calling
shader getGlobalIndex function at high frequency, so remove if-else
block.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is